Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nextcloud): Add support for AWS session token key #691

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(nextcloud): Add support for AWS session token key #691

wants to merge 2 commits into from

Conversation

refucktor
Copy link

Description of the change

  • Introduced a new configuration option for AWS Credentials to use a Session Token.
  • Updated template and values to enable usage of the new key

Benefits

  • Support using temporal AWS Credentials (e.g. STS assumed role)

Possible drawbacks

  • None

Applicable issues

Additional information

  • As you might notice, the session token is only referenced within an existing secret config, the nature of such session
    tokens comes from temporal credentials, more likely secrets auto-generated from sts assume role, etc. Therefore
    it only makes sense to reference it from an "existing secret"

Checklist

@refucktor
feat: Add support for S3 session token key
afb6f09 
- Introduced a new configuration option for S3 sessionTokenKey.
- Updated template and values to enable usage of this key

Signed-off-by: Hector Valcarcel <hmvalcarcel@gmail.com>
@refucktor refucktor marked this pull request as ready for review February 6, 2025 15:24
@refucktor
Merge branch 'main' into feat/support-aws-session-token
df5756c 
Signed-off-by: Hector Manuel <refucktor@users.noreply.github.com>
@wrenix wrenix self-requested a review March 6, 2025 15:34
wrenix
wrenix requested changes Mar 6, 2025
View reviewed changes
Copy link
Collaborator

@wrenix wrenix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODOs

  1. point we have to wait for a new release of the server:
    • in v30 current supported version of that helm-chart
    • in v31 current stable version of server

@wrenix wrenix changed the title Add support for AWS session token key feat(nextcloud): Add support for AWS session token key Mar 6, 2025
@wrenix wrenix added S3 Anything to do with S3 object storage blocked - upstream Blocked by an upstream repo or project. labels Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wrenix wrenix wrenix requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
blocked - upstream Blocked by an upstream repo or project. S3 Anything to do with S3 object storage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support AWS STS (AWS_SESSION_TOKEN) for S3 Object Storage
2 participants
@refucktor @wrenix