Hide footer in public share page #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The footer in the public share page is hidden by adding the "hidden" CSS class to the footer. However, the CSS rules for the footer defined in the server are more specific than the general rule for ".hidden" elements, which caused the footer to be shown even if marked as ".hidden". Now a more specific rule was added to override the ones from the server and ensure that the footer is hidden. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
rullzer
approved these changes
Sep 26, 2018
MorrisJobke
reviewed
Oct 2, 2018
| @@ -6,6 +6,10 @@ | |||
| display: block; | |||
| } | |||
|
|
|||
| #body-public footer.hidden { | |||
| display: none; | |||
There was a problem hiding this comment.
I have tested it again removing and adding the fix and for me it works as expected (footer visible without the fix, footer hidden with the fix).
Note that in your screenshot all the rules come from the server (the display: none is the generic one from the server, not the one from #body-public footer.hidden in style.css). Maybe a cache issue?
There was a problem hiding this comment.
Maybe also from gallery app or so?
|
Backport in #103 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The footer in the public share page is hidden by adding the
hiddenCSS class to the footer. However, the CSS rules for the footer defined in the server are more specific than the general rule for.hiddenelements, which caused the footer to be shown even if marked as.hidden. Now a more specific rule was added to override the ones from the server and ensure that the footer is hidden.Note that this problem occurs in all browsers; it is not related to IE 11.
Also note that, as the PDF viewer can not be closed in the public share page and thus the footer is never shown, the proper way to fix this would be to change the TemplateResponse in the DisplayController to a PublicTemplateResponse which makes possible to completely remove the footer from the rendered template, and then adjust the JavaScript code as needed.
Despite that I opted for the other approach for easier backport to
stable14, as this issue appeared in NC 14.0.0 Beta 4 (when the CSS rules for the footer were added in the server).