21: PHP 8 support/tests #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
blizzz
commented
Jan 8, 2021
•
blizzz
commented
- requires Bump doctrine/dbal from 2.12.0 to 3.0.0 server#24948
- requires Don't try a transaction for the migrator on MySQL server#25038
- drop the last commit
blizzz
force-pushed
the
enh/noid/prepare-21
branch
2 times, most recently
from
8015e43 to
d28505b
Compare
blizzz
changed the title
blizzz
force-pushed
the
enh/noid/prepare-21
branch
from
d28505b to
8417c2c
Compare
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
force-pushed
the
enh/noid/prepare-21
branch
2 times, most recently
from
d233a17 to
2a80822
Compare
| # do not stop on another job's failure | ||
| fail-fast: false | ||
| matrix: | ||
| php-versions: ['8.0'] |
There was a problem hiding this comment.
7.3+7.4? It's free, use it
ChristophWurst
approved these changes
Jan 11, 2021
| @@ -3,7 +3,7 @@ name: compatibility | |||
|
|
|||
| steps: | |||
| - name: syntax-php7.4 | |||
| image: nextcloudci/php7.4:2 | |||
| image: nextcloudci/php7.4:php7.4-3 | |||
There was a problem hiding this comment.
do all this with GH actions?
There was a problem hiding this comment.
Labour shared is labour halved.
(it actually ran fast then the github builds)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.