Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix url icon inline, closes #92 #99

Merged
merged 2 commits into from
Jan 24, 2017
Merged

Fix url icon inline, closes #92 #99

merged 2 commits into from
Jan 24, 2017

Conversation

skjnldsv
Copy link
Member

capture d ecran_2017-01-23_05-44-08

@skjnldsv
Fix url icon inline, closes #92
5540b23 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added 3. to review Waiting for reviews design Related to the design good first issue Good for newcomers labels Jan 23, 2017
@skjnldsv skjnldsv added this to the 1.5.3 milestone Jan 23, 2017
@skjnldsv skjnldsv self-assigned this Jan 23, 2017
@codecov-io
Copy link

codecov-io commented Jan 23, 2017 •
edited
Loading

Current coverage is 12.09% (diff: 100%)

Merging #99 into master will not change coverage

@@             master        #99   diff @@
==========================================
  Files            46         46          
  Lines           918        918          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            111        111          
  Misses          807        807          
  Partials          0          0

Powered by Codecov. Last update f4ee4e6...5540b23

ChristophWurst
ChristophWurst previously requested changes Jan 23, 2017
View reviewed changes
css/public/style.css
@@ -263,6 +263,8 @@ detailsitem .url-link {
padding: 8px 10px;
margin-left: -30px;
opacity: .5;
top: 2px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation looks odd :-)

@skjnldsv
Identation fix
2c2b441 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv dismissed ChristophWurst’s stale review January 23, 2017 13:45

Indeed! :D
Please review again!

jancborchardt
jancborchardt approved these changes Jan 24, 2017
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍

@jancborchardt jancborchardt merged commit 5bc7c9e into master Jan 24, 2017
@jancborchardt jancborchardt deleted the fix-url-link-inline branch January 24, 2017 00:56
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 4. to release Ready to be released and/or waiting for tests to finish 3. to review Waiting for reviews labels Feb 7, 2017
@wirepatch wirepatch mentioned this pull request Sep 22, 2017
Closed
@steve-s-71 steve-s-71 mentioned this pull request Oct 3, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

@ChristophWurst ChristophWurst ChristophWurst left review comments

@Henni Henni Awaiting requested review from Henni

@blizzz blizzz Awaiting requested review from blizzz

@irgendwie irgendwie Awaiting requested review from irgendwie

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish design Related to the design good first issue Good for newcomers
Projects
None yet
Milestone
1.5.3
Development

Successfully merging this pull request may close these issues.
4 participants
@skjnldsv @codecov-io @jancborchardt @ChristophWurst