Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @nextcloud/vue v7.0.0-beta.3 #2917

Merged
merged 1 commit into from
Sep 16, 2022
Merged

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Sep 9, 2022

Signed-off-by: greta gretadoci@gmail.com

@GretaD GretaD added the 2. developing Work in progress label Sep 9, 2022
@GretaD GretaD self-assigned this Sep 9, 2022
@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Base: 31.65% // Head: 67.96% // Increases project coverage by +36.30% 🎉

Coverage data is based on head (e411352) compared to base (bcd28ac).
Patch has no changes to coverable lines.

❗ Current head e411352 differs from pull request most recent head 54a990d. Consider uploading reports for the commit 54a990d to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #2917       +/-   ##
=============================================
+ Coverage     31.65%   67.96%   +36.30%     
  Complexity      253      253               
=============================================
  Files           104       23       -81     
  Lines          1832      721     -1111     
  Branches        211        0      -211     
=============================================
- Hits            580      490       -90     
+ Misses         1140      231      -909     
+ Partials        112        0      -112     
Impacted Files Coverage Δ
src/components/Actions/ActionCopyNtoFN.vue
src/components/Actions/ActionToggleYear.vue
src/components/AppContent/CircleContent.vue
src/components/AppContent/ContactsContent.vue
.../components/AppNavigation/CircleNavigationItem.vue
...c/components/AppNavigation/GroupNavigationItem.vue
src/components/AppNavigation/RootNavigation.vue
...nts/AppNavigation/Settings/SettingsAddressbook.vue
...ppNavigation/Settings/SettingsAddressbookShare.vue
...pNavigation/Settings/SettingsAddressbookSharee.vue
... and 71 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@GretaD GretaD force-pushed the upgrade/contact-to-vue7 branch from 97ac947 to 544c422 Compare September 13, 2022 08:47
@GretaD
Copy link
Contributor Author

GretaD commented Sep 13, 2022

the multiselect is the only problem i noticed while upgrading but please test
Screenshot from 2022-09-13 16-19-39

@GretaD GretaD marked this pull request as ready for review September 13, 2022 14:20
@GretaD GretaD added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 13, 2022
@GretaD GretaD changed the title Bump @nextcloud/vue v7.0.0-beta.1 Bump @nextcloud/vue v7.0.0-beta.3 Sep 14, 2022
@ChristophWurst

This comment was marked as resolved.

@ChristophWurst ChristophWurst marked this pull request as draft September 14, 2022 14:56
@ChristophWurst ChristophWurst added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Sep 14, 2022
@ChristophWurst ChristophWurst added this to the v5.0 milestone Sep 14, 2022
@ChristophWurst

This comment was marked as resolved.

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok

Signed-off-by: greta <gretadoci@gmail.com>
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Sep 16, 2022
@ChristophWurst ChristophWurst marked this pull request as ready for review September 16, 2022 15:14
@ChristophWurst ChristophWurst merged commit 61e9d9f into main Sep 16, 2022
@ChristophWurst ChristophWurst deleted the upgrade/contact-to-vue7 branch September 16, 2022 15:16
This was referenced Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants