Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow importing from files #1438

Merged
merged 2 commits into from
Feb 4, 2020
Merged

Allow importing from files #1438

merged 2 commits into from
Feb 4, 2020

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jan 24, 2020 •
edited
Loading

image

  • Modal
  • Design
  • Cancel should kill axios request if any
  • Jan's approval & changes
  • Cleanup old code

@skjnldsv skjnldsv added enhancement New feature or request 2. developing Work in progress high High priority labels Jan 24, 2020
@skjnldsv skjnldsv added this to the next minor milestone Jan 24, 2020
@skjnldsv skjnldsv self-assigned this Jan 24, 2020
@codecov

This comment has been minimized.

Sign in to view
@jancborchardt

This comment has been minimized.

Sign in to view
@skjnldsv

This comment has been minimized.

Sign in to view
@skjnldsv skjnldsv force-pushed the enh/import-from-files branch from 63ab8ae to 2f42183 Compare January 29, 2020 16:02
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 29, 2020
@skjnldsv skjnldsv requested a review from hanzi January 29, 2020 16:02
@skjnldsv skjnldsv force-pushed the enh/import-from-files branch from 6aee03f to 0d262fc Compare January 29, 2020 16:13
@skjnldsv
Copy link
Member Author

All good!
Please review ! 🎉

@skjnldsv
Allow importing from files
0ff05f5 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the enh/import-from-files branch from 0d262fc to 0ff05f5 Compare January 29, 2020 16:26
ChristophWurst
ChristophWurst approved these changes Feb 4, 2020
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good!

rullzer
rullzer approved these changes Feb 4, 2020
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it and does the trick!

@skjnldsv skjnldsv merged commit 100c91b into master Feb 4, 2020
@skjnldsv skjnldsv deleted the enh/import-from-files branch February 4, 2020 14:10
@tcitworld tcitworld mentioned this pull request Feb 4, 2020
Open
@skjnldsv skjnldsv modified the milestones: next minor, 3.1.7-3.1.9 Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@hanzi hanzi Awaiting requested review from hanzi

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews enhancement New feature or request high High priority
Projects
None yet
Milestone
3.1.7-3.1.9
Development

Successfully merging this pull request may close these issues.
4 participants
@skjnldsv @jancborchardt @rullzer @ChristophWurst