Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read-only/edit switch #3313

Closed
22 tasks
GretaD opened this issue Apr 17, 2023 · 1 comment
Closed
22 tasks

Read-only/edit switch #3313

GretaD opened this issue Apr 17, 2023 · 1 comment
Labels
1. to develop Accepted and waiting to be taken care of duplicate This issue or pull request already exists enhancement New feature or request

Comments

@GretaD
Copy link
Contributor

GretaD commented Apr 17, 2023

Is your feature request related to a problem? Please describe.

Improve the read-only/edit view on contacts

Describe the solution you'd like

Enhancements related to view/edit mode, including points from the original design review and previous mockups:

  • Use vue components
  • When a new contact is created:
    • It should be in edit mode
    • The name field should be focused and selected

View mode:

  • None of the fields are editable in view mode
  • They can be edited by clicking on an "Edit" button which takes you to Edit mode
  • Fields which are not filled are not shown
  • Don't show address books in view mode as it's kind of an obscure field
  • Convert "Title" and "Company" fields to read more nicely in view mode, for eg. Analyst at Company

Edit mode:

  • In edit mode, users can edit the properties and save using the "Save" button
  • Fields in the header (name, title, company) should look like input fields with the appropriate placeholder when they are empty
  • Fields that are not set are not shown
  • Groups are always shown even if the contact is not a part of any group yet so that they can be easily added. It can be the second-to-last item
  • Address book is shown in edit mode but as read-only (ie, similar to how it would be shown if it was in view mode). It can be the last item
  • The properties that already exist (Phone, email, address) have an option to add another value using a "+" icon on the right (eg. add another phone number for work)
  • Positions of all elements should remain consistent when editing (currently, "Title" field position shifts slightly when syncing to server)
  • If contact name is empty:
    • Should default to "New contact" on saving
    • Or the save button should be disabled
  • Order of newly added properties:
    • The newly added properties should appear in the same order as their position in the list of properties (If new "Phone" property is added, it will always show up as the first item, "Mail" is always second item, etc)
    • Scroll to the newly added property

Describe alternatives you've considered

No response

Additional context

231755324-1cc257a8-bd1e-427f-b806-38f778900c16
231748352-ba00dde3-3987-416a-aab0-ae86f928b256
231748464-39cc019e-a317-45e1-a271-65001583a94c

@GretaD GretaD added enhancement New feature or request 1. to develop Accepted and waiting to be taken care of labels Apr 17, 2023
@GretaD GretaD mentioned this issue Apr 17, 2023
73 tasks
@ChristophWurst ChristophWurst moved this to 📄 To do (~10 entries) in 💌 📅 👥 Groupware team Apr 17, 2023
@GretaD
Copy link
Contributor Author

GretaD commented Apr 18, 2023

closing as a duplication of #3284

@GretaD GretaD closed this as completed Apr 18, 2023
@github-project-automation github-project-automation bot moved this from 📄 To do (~10 entries) to ☑️ Done in 💌 📅 👥 Groupware team Apr 18, 2023
@GretaD GretaD added the duplicate This issue or pull request already exists label Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of duplicate This issue or pull request already exists enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant