Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement read-only/view mode for contact details view #3284

Closed
6 tasks done
Tracked by #1923
dschrempf opened this issue Mar 23, 2023 · 4 comments · Fixed by #3347
Closed
6 tasks done
Tracked by #1923

Implement read-only/view mode for contact details view #3284

dschrempf opened this issue Mar 23, 2023 · 4 comments · Fixed by #3347
Assignees
Labels
4. to release Ready to be released and/or waiting for tests to finish design Related to the design enhancement New feature or request

Comments

@dschrempf
Copy link

dschrempf commented Mar 23, 2023

Is your feature request related to a problem? Please describe.

When opening the contacts on Nextcloud, I am always afraid that I add or delete characters or other things to the fields by accident.

Describe the solution you'd like

  • When viewing a contact, the contact should be in "read-only" (or "viewing") mode by default.
  • There should be a button "Edit" to edit the contact
  • The "Save" button should be in the same place as the "Edit" button after toggling modes.
  • [Contact Details] Show quick actions in view mode #3352
  • Switch between view and edit mode should not cause jumping around of text. The text is placed such that on changing to edit mode, the position of the text itself changes as little as possible, and only a border appears around the text indicating an input field.
  • Switching between view and edit mode should not change the position of the Edit/save button either, esp. in mobile view.

Mockups are at #3305.

Describe alternatives you've considered

None

Additional context

Thanks for considering this feature request!

@dschrempf dschrempf added 0. Needs triage enhancement New feature or request labels Mar 23, 2023
@ChristophWurst
Copy link
Member

This is mentioned in #2699 too

@st3iny st3iny changed the title Read-only mode (and possibility to set as default) Implement read-only/view mode for contact details view Apr 14, 2023
@st3iny st3iny added 1. to develop Accepted and waiting to be taken care of design Related to the design and removed 0. Needs triage labels Apr 14, 2023
@st3iny
Copy link
Member

st3iny commented Apr 14, 2023

I added more bullet points from #1923 (comment).

@ChristophWurst
Copy link
Member

Let's also move and merge the todos and screenshots from #1923 (comment) into this ticket for better clarity.

@st3iny st3iny self-assigned this Apr 27, 2023
@st3iny st3iny added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Apr 27, 2023
@st3iny st3iny moved this from 📄 To do (~10 entries) to 🏗️ In progress in 💌 📅 👥 Groupware team Apr 27, 2023
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Apr 28, 2023
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 💌 📅 👥 Groupware team Apr 28, 2023
@dschrempf
Copy link
Author

Thank you so much for your work on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish design Related to the design enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

3 participants