-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement new dashboard APIs #4474
Conversation
Codecov ReportBase: 41.74% // Head: 41.86% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #4474 +/- ##
============================================
+ Coverage 41.74% 41.86% +0.11%
- Complexity 338 348 +10
============================================
Files 226 226
Lines 5603 5659 +56
Branches 738 738
============================================
+ Hits 2339 2369 +30
- Misses 3264 3290 +26
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
6213a1d
to
0e36cd7
Compare
@ChristophWurst I just realized Calendar supports NC >= 22. The new APIs will only be there from 25. How do you wanna deal with that? Bump the min NC version to 25? |
Needed for #4459 anyway |
@ChristophWurst I'm stuck in getting the next occurrence of the events instead of DTSTART. I don't want to implement an overkill method when something simple might already exist 😁. Could you point me to places to understand how it's done by the frontend widget? Do I have to compute it from the event repetition rules? |
@tcitworld True that, thanks for the remark. |
This comment was marked as outdated.
This comment was marked as outdated.
b4442cd
to
0a1fc97
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Testing is possible with: |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as off-topic.
This comment was marked as off-topic.
For my user bob who is not an admin it works well. <calendar>
<element>
<subtitle>in 4 days</subtitle>
<title>fdsddsf</title>
<link>http://nextcloud.local/index.php/apps/calendar/?objectId=e68c5668-c777-4069-bfc4-186113621b0d</link>
<iconUrl>http://nextcloud.local/index.php/apps/calendar/public/getCalendarDotSvg/%230082c9</iconUrl>
<sinceId>1666051200</sinceId>
</element>
<element>
<subtitle>in 7 days</subtitle>
<title>dsfdfsdfs</title>
<link>http://nextcloud.local/index.php/apps/calendar/?objectId=fb1883be-abad-4b3e-ba4a-df92180d5fab</link>
<iconUrl>http://nextcloud.local/index.php/apps/calendar/public/getCalendarDotSvg/%230082c9</iconUrl>
<sinceId>1666310400</sinceId>
</element>
<element>
<subtitle>in 10 days</subtitle>
<title>fdsfddsffdsdfssdsdfsdfsfddsf</title>
<link>http://nextcloud.local/index.php/apps/calendar/?objectId=48ec3b78-68f4-4278-be9d-799715fb04f1</link>
<iconUrl>http://nextcloud.local/index.php/apps/calendar/public/getCalendarDotSvg/%230082c9</iconUrl>
<sinceId>1666569600</sinceId>
</element>
<element>
<subtitle>in 11 days</subtitle>
<title>dssdadsasadasd</title>
<link>http://nextcloud.local/index.php/apps/calendar/?objectId=f2980c2e-5f8f-4153-9a41-9f90f55c6d8a</link>
<iconUrl>http://nextcloud.local/index.php/apps/calendar/public/getCalendarDotSvg/%23499AA2</iconUrl>
<sinceId>1666656000</sinceId>
</element>
<element>
<subtitle>in 12 days</subtitle>
<title>dsadsasdasadsad</title>
<link>http://nextcloud.local/index.php/apps/calendar/?objectId=bbd0e106-1473-4f0f-97ef-6270695616dc</link>
<iconUrl>http://nextcloud.local/index.php/apps/calendar/public/getCalendarDotSvg/%23499AA2</iconUrl>
<sinceId>1666742400</sinceId>
</element>
</calendar>
and the icons work and are in the right colour. |
This comment was marked as resolved.
This comment was marked as resolved.
93a8230
to
b085db3
Compare
084fa0a
to
62f2962
Compare
@tobiasKaminsky pls review! |
00f337e
to
5463bf5
Compare
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
5463bf5
to
9768191
Compare
closes #4451
requires nextcloud/server#33658
In progress