-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parameter preparation for occ command #518
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was on vacation, sorry for the delay in replying.
And why is PR made in stable31
branch? Maybe it would be better to make it in main and backport it?
@R0Wi good time of day. Are you willing to rebase this PR on |
Hi @oleksandr-nc, sorry for the delayed answer. Unfortunately I've been out sick last week. Happy to incorporate your review findings tonight 👍 |
* Fix for #517 Signed-off-by: Robin Windey <ro.windey@gmail.com>
275486f
to
85d7934
Compare
@oleksandr-nc rebased on |
/backport to stable31 |
Thank you |
occ
commandline paramsocc
command has been sent, nothing could be found in the logs)Notes
stable31
$this->config->getSystemValue('apps_paths')
with[]
, because I found some errors in my logs when trying to uninstall an app (something like "foreach needs an array, string given ..."). This happens ifapp_paths
is not set.getSystemValue
will return an "empty" string in that case.