Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable28] fix/1464 adapt visual your activities <h1> which remains the same through all activities pages #1515

Merged
merged 1 commit into from
Jan 16, 2024
Merged

[stable28] fix/1464 adapt visual your activities <h1> which remains the same through all activities pages #1515

merged 1 commit into from
Jan 16, 2024

Conversation

JuliaKirschenheuter
Copy link
Contributor

Manual backport of #1512

@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Jan 16, 2024
@JuliaKirschenheuter JuliaKirschenheuter changed the base branch from master to stable28 January 16, 2024 09:57
@susnux
Copy link
Contributor

susnux commented Jan 16, 2024

Something seems to be wrong with the signoff, DCO is red.

@JuliaKirschenheuter
Copy link
Contributor Author

Something seems to be wrong with the signoff, DCO is red.

I see but don't know what exactly is wrong because signoff is obviously there ;( Probably there are some problems with CI?

@JuliaKirschenheuter @susnux
adapt heading relied on the navigation item
719bfd6 
(cherry picked from commit 2fa1859)

Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
@susnux susnux force-pushed the stable28-fix/1464-Adapt_visual_Your_activities_<h1>_which_remains_the_same_through_all_activities_pages branch from 1d95cef to 719bfd6 Compare January 16, 2024 10:45
@susnux
Copy link
Contributor

susnux commented Jan 16, 2024

The signoff was duplicated

@cypress Cypress
Copy link

cypress bot commented Jan 16, 2024

Passing run #1141 ↗︎

0 10 0 0 Flakiness 0

Details:

[stable28] fix/1464 adapt visual your activities

which remains the same thr...
Project: Activity Commit: 46ff8fd26a
Status: Passed Duration: 02:20 💡
Started: Jan 16, 2024 10:49 AM Ended: Jan 16, 2024 10:51 AM

Review all test suite changes for PR #1515 ↗︎

@susnux
Copy link
Contributor

susnux commented Jan 16, 2024

/compile amend

@susnux
Copy link
Contributor

susnux commented Jan 16, 2024

/compile

@susnux susnux merged commit 66a83a1 into stable28 Jan 16, 2024
43 checks passed
@susnux susnux deleted the stable28-fix/1464-Adapt_visual_Your_activities_<h1>_which_remains_the_same_through_all_activities_pages branch January 16, 2024 15:41
@blizzz blizzz mentioned this pull request Jan 17, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@ShGKme ShGKme ShGKme approved these changes

@artonge artonge Awaiting requested review from artonge

@emoral435 emoral435 Awaiting requested review from emoral435

@Pytal Pytal Awaiting requested review from Pytal

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels
3. to review feedback-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JuliaKirschenheuter @susnux @ShGKme