Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add npm-publish #14

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Add npm-publish #14

merged 1 commit into from
Jul 27, 2021

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Jul 23, 2021

To be dispatched to @nextcloud namespaced npm package repositories :)

@Pytal Pytal added 3. to review Waiting for reviews enhancement New feature or request labels Jul 23, 2021
@Pytal Pytal self-assigned this Jul 23, 2021
@Pytal Pytal mentioned this pull request Jul 23, 2021
Closed
@Pytal Pytal force-pushed the feat/npm-publish branch from e4a5214 to 810a8ad Compare July 24, 2021 00:18
@Pytal Pytal mentioned this pull request Jul 24, 2021
Closed
skjnldsv
skjnldsv approved these changes Jul 24, 2021
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpick, but looks great! 🚀

skjnldsv
skjnldsv requested changes Jul 24, 2021
View reviewed changes
@Pytal
Add npm-publish
5e63cd2 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the feat/npm-publish branch from 05e9278 to 5e63cd2 Compare July 27, 2021 02:53
@Pytal Pytal requested a review from skjnldsv July 27, 2021 02:55
@skjnldsv skjnldsv merged commit f651132 into master Jul 27, 2021
@skjnldsv skjnldsv deleted the feat/npm-publish branch July 27, 2021 06:17
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 27, 2021
This was referenced May 18, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@artonge artonge Awaiting requested review from artonge

@szaimen szaimen Awaiting requested review from szaimen

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pytal @skjnldsv