refactor: Use boolean props with default value false #6452
Merged
+53
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
3. to review
|
/backport to next |
Provide `disableSwipe` instead of `allowSwipeNavigation` (`NcAppContent`) and `enableSwipe` (`NcModal`). Boolean prop should always - when possible - have a default value of `false` to allow shorthand prop assignment in the template. Similar to native HTML boolean attributes: ```vue <!-- native HTML --> <button disabled> <!-- boolean Vue prop with default false --> <NcModal disable-swipe> ``` Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
refactor/boolean-props-1
branch
from
852c87e to
b76ed2a
Compare
GretaD
approved these changes
Jan 24, 2025
Antreesy
approved these changes
Feb 12, 2025
| /** | ||
| * Enable swipe between slides | ||
| * @deprecated Will be removed in next version - use `disableSwipe` instead |
There was a problem hiding this comment.
Not blocking, but don't forget to replace it for next
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Provide
disableSwipeinstead ofallowSwipeNavigation(NcAppContent) andenableSwipe(NcModal).Boolean prop should always - when possible - have a default value of
falseto allow shorthand prop assignment in the template. Similar to native HTML boolean attributes:🏁 Checklist
nextrequested with a Vue 3 upgrade