-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NcAppNavigation): Fix sidebar position in RTL and mobile mode. #6260
Merged
skjnldsv
merged 1 commit into
nextcloud-libraries:master
from
falghamdi125:add-RTL-support-to-nav-sidebar
Dec 11, 2024
Merged
fix(NcAppNavigation): Fix sidebar position in RTL and mobile mode. #6260
skjnldsv
merged 1 commit into
nextcloud-libraries:master
from
falghamdi125:add-RTL-support-to-nav-sidebar
Dec 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
approved these changes
Nov 25, 2024
ShGKme
requested changes
Nov 26, 2024
ff1792f
to
9a07e8e
Compare
ShGKme
approved these changes
Nov 29, 2024
Thanks |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6260 +/- ##
==========================================
- Coverage 42.62% 42.30% -0.33%
==========================================
Files 154 154
Lines 4040 3988 -52
Branches 1017 1023 +6
==========================================
- Hits 1722 1687 -35
+ Misses 2206 2190 -16
+ Partials 112 111 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Faisal Alghamdi <falghamdi125@gmail.com>
9a07e8e
to
2ed3522
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3. to review
Waiting for reviews
bug
Something isn't working
feature: app-sidebar
Related to the app-sidebar component
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
So, in RTL mode, the sidebar slides from the right not the left like in LTR mode.
Now, we have to adjust apps headers margins and padding for RTL mode to accomedate the toggle button that'll be displayed on the right.
🖼️ Screenshots
Best