Automated styling update from server #5887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nextcloud-command
added
3. to review
Signed-off-by: GitHub <noreply@github.com>
nextcloud-command
force-pushed
the
automated/noid/server-styling-update
branch
from
2ae7ab5 to
68a28c0
Compare
Antreesy
approved these changes
Aug 1, 2024
ShGKme
reviewed
Aug 1, 2024
| @@ -441,7 +441,7 @@ export default { | |||
| margin-inline: var(--input-padding-start) var(--input-padding-end); | |||
| max-width: fit-content; | |||
| font-size: var(--input-label-font-size); | |||
| inset-block-start: calc((var(--default-clickable-area) - var(--default-line-height)) / 2); // center the label vertically | |||
| inset-block-start: calc((var(--default-clickable-area) - 1lh) / 2); // center the label vertically | |||
There was a problem hiding this comment.
This is not Automated styling update from server 👀
There was a problem hiding this comment.
First commit is 🦭
I can move it to separate PR, but it'll take more efforts
There was a problem hiding this comment.
and dark.css isn't updated for some reason..
There was a problem hiding this comment.
and dark.css isn't updated for some reason..
Yes, it is not automated. Same with Talk Desktop — default styles are available from source, but theming required a PHP server
Antreesy
force-pushed
the
automated/noid/server-styling-update
branch
from
0cb8762 to
fca6dd5
Compare
ShGKme
reviewed
Aug 1, 2024
ShGKme
reviewed
Aug 1, 2024
Oops, I missed with lh function. Not very well supported, but works in FF |
Antreesy
force-pushed
the
automated/noid/server-styling-update
branch
from
fca6dd5 to
68a28c0
Compare
|
Dropped changes in favor of separate PR |
ShGKme
approved these changes
Aug 1, 2024
3 tasks
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
|
Cypress still failing |
marcoambrosini
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto-generated update of our locally cached css styling from