-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NcActionInput): allow to append NcSelect
to body
#5017
Conversation
Then an alternative solution could be to emulate Vue 3 behavior:
It would allow avoiding adding a specific prop for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great fix :) As @marcoambrosini has mentioned we should generally move away from nesting components in an ActionMenu though :)
713cc90
to
5b5aec0
Compare
I think this is the best solution, as it saves us from adding a prop. I changed it accordingly. It just has a tiny flaw, that one has to correctly name the attribute, as only |
@nimishavijay You seem to have no write access to the repository, so I cannot merge yet 🙂 Is this on purpose, or should you be granted access by someone who can? |
NcSelect
to body
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
5b5aec0
to
e619b2e
Compare
☑️ Resolves
NcSelect
inNcActionInput
to body. This prevents clipping the select by the action menu.Code-wise it would be simpler to just remove
:append-to-body="false"
, but this would introduce a breaking change, as it would setappend-to-body
totrue
by default forNcSelect
. So I decided to add a prop instead.Also, for vue 3 this is not necessary, since
v-bind="$attrs"
overwrites the props already set on the component.🖼️ Screenshots