Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[next] feat(NcContent): migrate to vue 3 #4831

Merged
merged 1 commit into from
Nov 16, 2023
Merged

[next] feat(NcContent): migrate to vue 3 #4831

merged 1 commit into from
Nov 16, 2023

Conversation

raimund-schluessler
Copy link
Contributor

@raimund-schluessler raimund-schluessler commented Nov 16, 2023 •
edited
Loading

☑️ Resolves

  • This migrates NcContent and NcApp* components to vue3. NcAppSidebar* is not included yet, since this is needs larger adjustments.

One notable change is that NcContent behaves a bit different now. This is due to vue 3 which does not replace the element to which the app is mounted, but inserts into it, see https://v3-migration.vuejs.org/breaking-changes/mount-changes.html#mounted-application-does-not-replace-the-element. Hence, the HTML structure of the apps will change a bit from

<body>
	...
	<div id="content-vue" class="app-files content">
	</div>
</body>

to

<body>
	...
	<main id="content" class="app-files">
		<div id="content-vue" class="app-files content">
		</div>
	</main>
</body>

@raimund-schluessler raimund-schluessler added 2. developing Work in progress feature: app-navigation Related to the app-navigation component feature: app-content Related to the app-content component vue 3 Related to the vue 3 migration labels Nov 16, 2023
@raimund-schluessler raimund-schluessler added this to the 9.0.0 next Vue 3 milestone Nov 16, 2023
@raimund-schluessler raimund-schluessler force-pushed the feat/2154/content branch 2 times, most recently from 2353193 to 4e4b526 Compare November 16, 2023 09:15
@raimund-schluessler raimund-schluessler changed the title feat(NcContent): migrate to vue 3 [next] feat(NcContent): migrate to vue 3 Nov 16, 2023
@raimund-schluessler
feat(NcContent): migrate to vue 3
a0f14ed 
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@raimund-schluessler raimund-schluessler marked this pull request as ready for review November 16, 2023 09:40
@raimund-schluessler raimund-schluessler added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 16, 2023
@raimund-schluessler raimund-schluessler merged commit fb98fc6 into next Nov 16, 2023
@raimund-schluessler raimund-schluessler deleted the feat/2154/content branch November 16, 2023 12:04
@susnux susnux mentioned this pull request Jan 23, 2024
Merged
1 task
@ShGKme ShGKme mentioned this pull request Jul 18, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@ShGKme ShGKme ShGKme approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@Pytal Pytal Awaiting requested review from Pytal

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees
No one assigned
Labels
3. to review Waiting for reviews feature: app-content Related to the app-content component feature: app-navigation Related to the app-navigation component vue 3 Related to the vue 3 migration
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@raimund-schluessler @susnux @ShGKme