chore(vue3): Migrate NcEmojiPicker #4563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raimund-schluessler
added
3. to review
raimund-schluessler
added
2. developing
raimund-schluessler
force-pushed
the
chore/2154/emoji-picker
branch
from
19361fa to
859c114
Compare
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
raimund-schluessler
force-pushed
the
chore/2154/emoji-picker
branch
from
859c114 to
757427b
Compare
| @@ -393,6 +391,7 @@ export default { | |||
| background-color: var(--color-main-background) !important; | |||
| border: 0; | |||
| color: var(--color-main-text) !important; | |||
| display: flex !important; | |||
There was a problem hiding this comment.
The component keeps overwriting display: flex; with display: inline-block, which breaks the scrolling. So I force it here for now.
The default is to display the emoji from a remote data source, which we don't want (and is prohibitted by our CSP anyway). Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
raimund-schluessler
requested review from
susnux,
mejo-,
skjnldsv,
Pytal and
ShGKme
ShGKme
approved these changes
Oct 2, 2023
mejo-
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates
NcEmojiPickerto vue 3 and pulls in two commits frommaster.