fix: Node.move should also adjust the displayname
#1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The displayname is always set by Nextcloud, so if it is not a custom one it is set to the basename. This means on move (and rename) we need to update the displayname. This is an alternative to nextcloud/server#46474 We should consider making the displayname a top-level attribute like basename. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
added
type: bug
Bundle ReportChanges will increase total bundle size by 1.75kB ⬆️
|
I guess so yes! 👍 |
4 tasks
For legacy reasons a fallback is still used to move it from the `attributes` as otherwise this would be breaking. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
skjnldsv
approved these changes
Jul 18, 2024
…e-as-top-level
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The displayname is always set by Nextcloud,
so if it is not a custom one it is set to the basename. This means on move (and rename) we need to update the displayname.
This is an alternative to nextcloud/server#46474
We should consider making the displayname a top-level attribute like basename (cc @skjnldsv ?)