Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV-4435 | sprintly dependencies upgrade #1409

Merged
merged 3 commits into from
Feb 14, 2024

Conversation

benjaminEwhite
Copy link
Contributor

@benjaminEwhite benjaminEwhite commented Feb 12, 2024

Please fill out each section even if it's just with "N/A"

Plan? (if this draft/incomplete indicate what you intend to do and how)

What's this PR do?

  • Sprintly server-side dependencies upgrade
  • Pins pytest to v7 for now, because of incompatibility of 8 with pytest asyncio, which is a sub dependency. (See here in GH for pytest, for more details).
  • Makes small change to apps/users/views.py::password_reset_token_created because that function broke in case of non-authed request with upgrade of django-rest-passwordreset
  • All of the remaining changes are formatting changes introduced by updating pre-commit

Why are we doing this? How does it help us?

Sprintly process to help with security and bug fixes of third party packages.

Are there detailed, specific, step-by-step testing instructions in the associated ticket?

N/A

Did this PR make changes to the user interface that may require changes to the user-facing docs?

No

Have automated unit tests been added? If not, why?

N/A

How should this change be communicated to end users?

N/A

Are there any smells or added technical debt to note?

No

Has this been documented? If so, where?

N/A

What are the relevant tickets? Add a link to any relevant ones.

DEV-4435

Do any changes need to be made before deployment to production (adding environment variables, for example)? If so, open a ticket and link it to the ticket for this PR and list it here:

No

Are there next steps? If so, what? Have tickets been opened for them? List next-step tickets here:

N/A

@x110dc x110dc temporarily deployed to rev-engine-dev-4435-dep-nefrrk February 12, 2024 14:38 Inactive
@benjaminEwhite benjaminEwhite marked this pull request as ready for review February 12, 2024 14:39
@benjaminEwhite benjaminEwhite temporarily deployed to rev-engine-dev-4435-dep-nefrrk February 12, 2024 15:45 Inactive
@benjaminEwhite benjaminEwhite temporarily deployed to rev-engine-dev-4435-dep-nefrrk February 12, 2024 15:46 Inactive
x110dc
x110dc previously requested changes Feb 13, 2024
Copy link
Member

@x110dc x110dc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should note in the PR description that formatting changes were made, especially since it's the majority of the files changed. Otherwise LGTM.

@benjaminEwhite
Copy link
Contributor Author

Updated PR description @x110dc

@benjaminEwhite benjaminEwhite dismissed x110dc’s stale review February 14, 2024 01:37

In Jira Daniel said could address and no need for re-review.

@benjaminEwhite benjaminEwhite removed the request for review from nrh-cklimas February 14, 2024 01:37
@nrh-cklimas nrh-cklimas merged commit 35c8c9e into main Feb 14, 2024
9 checks passed
@nrh-cklimas nrh-cklimas deleted the DEV-4435-deps-upgrade-rev-engine-backend branch February 14, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants