Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[newrelic-logging] Configurable Kubernetes filter HTTP buffer size #621

Merged
merged 2 commits into from
Jan 14, 2022
Merged

[newrelic-logging] Configurable Kubernetes filter HTTP buffer size #621

merged 2 commits into from
Jan 14, 2022

Conversation

rlees85
Copy link
Contributor

@rlees85 rlees85 commented Dec 15, 2021

Allow Kubernetes filter http buffer size to be configured since many pod templates now exceed 32k.

Is this a new chart

No

What this PR does / why we need it:

Allow Kubernetes filter http buffer size to be configured since many pod templates now exceed 32k.

Which issue this PR fixes

Cannot find open issue. Fixes issue where logs are dropped for certain pods that contain a large template. The following is in the newrelic logging agent logs:

[2021/11/04 13:49:51] [ warn] [http_client] cannot increase buffer: current=32000 requested=64768 max=32000

Fixes the issue without having to maintain an entire custom filters block in Helm values.

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [mychartname])

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@CLAassistant
Copy link

CLAassistant commented Dec 15, 2021

CLA assistant check
All committers have signed the CLA.

@rlees85
Copy link
Contributor Author

rlees85 commented Dec 15, 2021

Related: #570

@rediphone
Copy link

Hi there, this would be helpful for me, please could we get this in I have problems with logs that this would resolve - thanks!

@rediphone
Copy link

Hi guys, sorry to chase but it would be great to get this in - i have an issue which this PR would resolve. if there is a problem please can we discuss what this issue is

thanks very much

@rediphone
Copy link

any possibility to progress this please
@jsubirat
@tejunior

@nadiamoe
Copy link
Contributor

nadiamoe commented Jan 14, 2022

Hey there,

Just my two cents here, I think we might benefit to a more flexible solution that allows users to define arbitrary options in the values.yaml that get appended to the filters. This should scale better and would not require users to open a PR for each new Fluentbit flag they want to change. I've seen this PR but I'm not sure if allows exactly this.

WDYT @newrelic/logging ?

@tejunior
Copy link
Contributor

More resources about this issue:
fluent/fluent-bit#2033
fluent/fluent-bit#3112

@tejunior tejunior merged commit 20938d3 into newrelic:master Jan 14, 2022
@rlees85
Copy link
Contributor Author

rlees85 commented Jan 17, 2022

@roobre I also like this idea, but sadly I don't think that PR will permit it since we are wanting to add settings to an existing (Kubernetes) filter rather than adding new filter blocks. I am not sure if fluentd/fluentbit stacks "same" filter blocks.

@rlees85 rlees85 deleted the k8s_http_buffer_size branch January 17, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants