New 'update' event signature #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To verify the modification, I suggest you to start commit by commit (easier to see the diffs). |
| if (animDuration > 0) { | ||
| elem.mapElem.animate({"opacity":0}, animDuration, "linear", function() { | ||
| $self.on("update", function(e, opt) { | ||
| if (typeof opt === "object") { |
There was a problem hiding this comment.
What do you think about replacing the huge condition if (typeof opt === "object") { ...} by if (typeof opt !== "object") return; in order to decrease the indentation level ?
|
Here we go :-) |
|
Nice, thank you ! I agree with you, the diff tool should provide an option to ignore diffs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #105