Make create folders logging optional #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
JoeZiminski
force-pushed
the
make_create_folders_logging_optional
branch
from
1bd6716 to
4497f42
Compare
Base automatically changed from
fix_logger_name_regression
to
deprecate_python3.8_add3.12
June 9, 2024 15:31
JoeZiminski
force-pushed
the
make_create_folders_logging_optional
branch
from
4497f42 to
2e8420e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes an option to make logging optional on
create_folders.No documentation or tests are required. I suppose it could be tested that setting to
Falseactually stops logging, it is already tested thatcreate_foldersdoes log ifTrue. But seems overkill.This PR requires #384 to be merged because some fixes in the logging were discovered during this PR.