fix: multiple plugin versions in a monorepo setup #6105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request adds or modifies JavaScript ( |
|
This pull request adds or modifies JavaScript ( |
pieh
previously approved these changes
Feb 27, 2025
There was a problem hiding this comment.
Fix and test are great, just added minor suggestion to add some context about problem the test is asserting on and what's expected behavior (as assertion itself requires some understanding and might not be self explanatory, so to just save some confusion in the future I suggested some comments)
Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
|
This pull request adds or modifies JavaScript ( |
pieh
approved these changes
Feb 27, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Patch the system to support multiple version of plugins (e.g. next-runtime) in a monorepo context
Bonus: Package version bump for resolve
Fixes FRB-1641
For us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
your code follows our style guide and passes our tests.
A picture of a cute animal (not mandatory, but encouraged)