Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating documentation for iaf_psc_exp and iaf_cond_exp #3311

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Updating documentation for iaf_psc_exp and iaf_cond_exp #3311

wants to merge 4 commits into from

Conversation

zbarni
Copy link

@zbarni zbarni commented Sep 13, 2024

Removed redundant w_j from the equation of the synaptic current in the iaf_psc_exp model.

Extended and updated documentation for iaf_cond_exp.

@jessica-mitchell jessica-mitchell added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Sep 16, 2024
ackurth
ackurth approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@ackurth ackurth left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

jessica-mitchell
jessica-mitchell approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@jessica-mitchell jessica-mitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks lgtm!

@jessica-mitchell
Copy link
Contributor

@zbarni To fix the clang-format build error: could you please add the clang-format command before and after the begin user docs section
// clang-format off to line 58
and
// clang-format on to line 196

@github-actions GitHub Actions
Copy link

Pull request automatically marked stale!

@github-actions github-actions bot added the stale Automatic marker for inactivity, please have another look here label Feb 28, 2025
@github-actions github-actions bot removed the stale Automatic marker for inactivity, please have another look here label Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessica-mitchell jessica-mitchell jessica-mitchell approved these changes

@ackurth ackurth ackurth approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Documentation
Status: In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zbarni @jessica-mitchell @ackurth