This repository has been archived by the owner on Sep 13, 2022. It is now read-only.
fix(binding):overflow of StoreUint64 trait, modify foo_ to inner_foo #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Accept request. |
cosinlink
changed the title
|
Accept request. |
|
Docker builded. "mutadev/muta:aa3c7a7" |
yejiayu
reviewed
Apr 21, 2020
yejiayu
reviewed
Apr 21, 2020
|
|
Accept request. |
|
Docker builded. "mutadev/muta:83d59ac" |
|
Accept request. |
nolanxyg
reviewed
Apr 22, 2020
| } | ||
| } | ||
| } | ||
|
|
||
| impl<S: ServiceState> StoreUint64 for DefaultStoreUint64<S> { | ||
| fn get(&self) -> u64 { | ||
| self.get_() | ||
| .unwrap_or_else(|e| panic!("StoreUint64 get failed: {}", e)) | ||
| self.inner_get() |
There was a problem hiding this comment.
I think we can remove fn inner_xx method, and move the logic to fn xx trait method.
The reason of inner_xx existed is historical.
There was a problem hiding this comment.
Agreed, but refactoring may not be included here because the focus of this PR is to solve the overflow.
|
Docker builded. "mutadev/muta:0b0c6d8" |
nolanxyg
reviewed
Apr 22, 2020
protocol/src/traits/binding.rs
Outdated
| @@ -234,27 +234,27 @@ pub trait StoreUint64 { | |||
|
|
|||
| // Add val with self | |||
| // And set the result back to self | |||
| fn add(&mut self, val: u64); | |||
| fn add(&mut self, val: u64) -> bool; | |||
There was a problem hiding this comment.
How about name the method fn safe_xx ?
Because we had took care of math overflow.
|
Accept request. |
|
Docker builded. "mutadev/muta:c2995d9" |
yejiayu
previously approved these changes
Apr 22, 2020
nolanxyg
previously approved these changes
Apr 22, 2020
|
|
Accept request. |
|
Docker builded. "mutadev/muta:c4da9fd" |
|
Accept request. |
|
Docker builded. "mutadev/muta:e996965" |
|
yejiayu
approved these changes
Apr 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
bug
What this PR does / why we need it:
fix bug of StoreUint64 overflow panic
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: