Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shutdown issues #516

Open
wants to merge 20 commits into
base: develop
Choose a base branch
from

Conversation

chenyukang
Copy link
Collaborator

@chenyukang chenyukang commented Feb 19, 2025

Fixes #503
Fixes #333

Changes including:

  1. Refactor shutdown-related code, merge the logic of tracing transaction (tx) within the force shutdown to the normal shutdown logic
  2. Channel status is changed to "Closed" status only after the trace tx returns a confirmed result.
  3. Fix the issue of the error in the first hop wasn't recorded in the payment session fb04bb9#diff-176f6d4f89e68f8dda8ca44f71496fbfc28d7fbf135f1b5f2795c8a183a0bc18L1736-R1749
  4. Remove tlc waiting for ack when shutdown procedure started 12bd2fb

@chenyukang chenyukang marked this pull request as draft February 19, 2025 08:24
@chenyukang chenyukang changed the title [WIP] Fix shutdown issues Fix shutdown issues Feb 25, 2025
@chenyukang chenyukang marked this pull request as ready for review February 25, 2025 11:22
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 90.52632% with 18 lines in your changes missing coverage. Please review.

Project coverage is 50.27%. Comparing base (d8b1917) to head (19f3ed5).

Files with missing lines Patch % Lines
src/fiber/channel.rs 90.66% 14 Missing ⚠️
src/fiber/network.rs 90.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #516      +/-   ##
===========================================
+ Coverage    50.02%   50.27%   +0.25%     
===========================================
  Files           49       49              
  Lines        32389    32442      +53     
===========================================
+ Hits         16201    16309     +108     
+ Misses       16188    16133      -55     
Flag Coverage Δ
unittests 50.27% <90.52%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants