Experimental autocompletion setup scripts #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentyi
force-pushed
the
feat/completion_scripts
branch
from
3559b73 to
45c1107
Compare
|
Oh sweet! This seems like the easiest way to install autocomplete, I like it! Also down the line we can consider adding a FYI blurb at the beginning of training with the command if the install is not detected. Figuring out how to make this robust may need a bit of thinking.
Lol |
tancik
approved these changes
Sep 9, 2022
brentyi
force-pushed
the
feat/completion_scripts
branch
from
45c1107 to
476b2db
Compare
tancik
reviewed
Sep 13, 2022
| return True | ||
|
|
||
|
|
||
| def _exclamation() -> str: |
brentyi
force-pushed
the
feat/completion_scripts
branch
from
a56d8ed to
f272ec2
Compare
brentyi
changed the title
chris838
pushed a commit
to chris838/nerfstudio
that referenced
this pull request
Apr 22, 2023
* Working completion scripts * generate.py => install.py * Uninstall for completions, docs/README updates * Tune emojis, improve concurrency for completion install * wip * Cleanup * Permissions, shebang checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prototype for some thoughts @tancik
The tldr is that running:
Will (1) generate a completion script for every dcargs CLI in the
nerfactory/scriptsdirectory, and then (2) add a one-line update to the user's.bashrcand/or.zshrc(after asking for permission).The next shell they open should have completion enabled; I think this should just magically work, but haven't tested very thoroughly.
Misc notes: