fix: check workspace after client initial

[glepnir]

Problem

logic bug

Solution

rewrite

Fix #2355

[folke]

Can confirm that the lastest commits here fix #2355!

[glepnir]

hmmm wired . there has something I don't know , as the sumneko's wiki said there need restart server after insert workspace. I just send the didChangeworkspacefolders request to it . if server need restart that mean client.stop then
start new client ? this will spawn a new process with new pid, we don't have client.restart function, use new config start or use config with attached_buffers and workspace_folders data from before client ? I don't know here how the sumeko lua-language-server work..

https://github.com/sumneko/lua-language-server/wiki/Developing#multiple-workspace-support

[folke]

Looking at the sumneko code, it does actually support dyanmically changing the workspace folders, but before this PR, diagnostics for the current buffer would be wrong. Haven't checked your PR here, but the incorrect diagnostics now no longer show up.

[folke]

Should I re-open that linked sumneko issue?

[glepnir]

it does actually support dyanmically changing the workspace folders

don't look at the sumneko code .if it support maybe wiki is old.

but the incorrect diagnostics now no longer show up.

Just to make sure this PR solves the actual problem. I will wait for you to use it for a while. If it doesn't have any problems anymore I will merge.

Should I re-open that linked sumneko issue?

maybe not. we don't have any handlers for request workspace/diagnostic? / * in core and I also don't see them in lsp-mode lsp-bridge vim-lsp yegappan/lsp .. as lsp spec said this is useful. don't know why there.

https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#workspace_diagnostic

[folke]

Oh right. I actually implemented the workspace/diagnostic/refresh handler in my config. Still need to upstream that to core. Or maybe that's already in core in the meantime. Need to check.

[glepnir]

there has something to do in core diagnostic , I only have a rough idea of how workspace/diagnostic works, but it will take some trying when i have time .

[glepnir]

now confirm right ?

[folke]

I've done more testing and this PR seems to fix the issues I had with diagnostics.

[glepnir]

thanks for your kind reply.