Added permission check to the known_host file #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if( !knownHosts.canWrite() ) | ||
| { | ||
| throw new IOException( format( | ||
| "Failed to write certificates to file %s as you have no write permissions to it. " + |
There was a problem hiding this comment.
Would appreciate if you could add a \n after the first sentence in these messages, just like the ones below for CertificateException.
to give user more information about why we failed to read/write to the known_host file
zhenlineo
force-pushed
the
1.0-permission-to-known-host-file
branch
from
44927b0 to
757ae3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to give user more information about why we failed to read/write to the known_host file