Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade refactor-nrepl #198

Merged
merged 1 commit into from
Oct 26, 2021
Merged

Conversation

vemv
Copy link
Contributor

@vemv vemv commented Oct 26, 2021

Brief

Uses latest, which since is compatible with all sorts of nREPL clients (modern and legacy alike) makes unnecessary the extended profile/matrix.

The relevant changes for f-s is the reduced chance for false positives when cleaning up a ns form. This makes our workarounds around refactor-nrepl less necessary, however I wouldn't particularly recommend removing them (at least for a while; I'd like to increase test coverage for that area of refactor-nrepl first).

QA plan

None. There aren't breaking changes: https://github.com/clojure-emacs/refactor-nrepl/blob/a3f9de809b1246101786ec6160df3b8c66585f74/CHANGELOG.md#300-2021-10-25

Author checklist

  • I have QAed the functionality
  • The PR has a reasonably reviewable size and a meaningful commit history
  • I have run the branch formatter and observed no new/significative warnings
  • The build passes
  • I have self-reviewed the PR prior to assignment
  • Additionally, I have code-reviewed iteratively the PR considering the following aspects in isolation:
    • Correctness
    • Robustness (red paths, failure handling etc)
    • Test coverage
    • Spec coverage
    • Documentation
    • Security
    • Performance
    • Breaking API changes
    • Cross-compatibility (Clojure/ClojureScript)

Reviewer checklist

  • I have checked out this branch and reviewed it locally, running it
  • I have QAed the functionality
  • I have reviewed the PR
  • Additionally, I have code-reviewed iteratively the PR considering the following aspects in isolation:
    • Correctness
    • Robustness (red paths, failure handling etc)
    • Test coverage
    • Spec coverage
    • Documentation
    • Security
    • Performance
    • Breaking API changes
    • Cross-compatibility (Clojure/ClojureScript)

Uses latest, which since is compatible with all sorts of nREPL clients (modern and legacy alike) makes unnecessary the extended profile/matrix.
@vemv vemv marked this pull request as ready for review October 26, 2021 16:53
Copy link
Member

@thumbnail thumbnail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is working on my side (including tests). Thanks for this one 👍

@thumbnail thumbnail merged commit 465ecbd into nedap:main Oct 26, 2021
@vemv vemv deleted the upgrade-refactor-nrepl branch October 26, 2021 20:31
@vemv
Copy link
Contributor Author

vemv commented Oct 26, 2021

🍻!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants