Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Eastwood #142

Merged
merged 1 commit into from
Mar 3, 2020
Merged

Upgrade Eastwood #142

merged 1 commit into from
Mar 3, 2020

Conversation

vemv
Copy link
Contributor

@vemv vemv commented Mar 2, 2020 •
edited by thumbnail
Loading

Brief

  • Upgrade Eastwood
    • Ships: performance improvements (which I could verify), various bugfixes
  • Remove our workarounds
    • Don't remove contains-dynamic-assertions? yet - if we had to undo, it'd create churn in the Git history

QA plan

Lint project, verify no extraneous warnings, and no 'performance leak' (growing runtime due to the atom business)

Could be nice to do it over a monorepo.

Author checklist

  • I have QAed the functionality
  • The PR has a reasonably reviewable size and a meaningful commit history
  • I have run the branch formatter and observed no new/significative warnings
  • The build passes
  • I have self-reviewed the PR prior to assignment
  • Additionally, I have code-reviewed iteratively the PR considering the following aspects in isolation:
    • Correctness
    • Robustness (red paths, failure handling etc)
    • Modular design
    • Test coverage
    • Spec coverage
    • Documentation
    • Security
    • Performance
    • Breaking API changes
    • Cross-compatibility (Clojure/ClojureScript)

Reviewer checklist

  • I have checked out this branch and reviewed it locally, running it
  • I have QAed the functionality
  • I have reviewed the PR
  • Additionally, I have code-reviewed iteratively the PR considering the following aspects in isolation:
    • Correctness
    • Robustness (red paths, failure handling etc)
    • Modular design
    • Test coverage
    • Spec coverage
    • Documentation
    • Security
    • Performance
    • Breaking API changes
    • Cross-compatibility (Clojure/ClojureScript)

@vemv vemv marked this pull request as ready for review March 2, 2020 18:15
@vemv vemv requested a review from thumbnail March 2, 2020 18:15
thumbnail
thumbnail approved these changes Mar 3, 2020
View reviewed changes
Copy link
Member

@thumbnail thumbnail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working in monorepo 👍

@vemv
Copy link
Contributor Author

vemv commented Mar 3, 2020

🚀

@vemv vemv merged commit 6bb7b03 into master Mar 3, 2020
@vemv vemv deleted the upgrade-eastwood--v2 branch March 3, 2020 14:53
@vemv vemv mentioned this pull request Mar 4, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thumbnail thumbnail thumbnail approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vemv @thumbnail