Enable GCD on non-Linux POSIX if not configured

[BurningEnlightenment]

I assumed CMake would take care of this, but I was mistaken.

[BurningEnlightenment]

need to rebase after the duplicated inline error is fixed.

[ned14]

I fixed the quickcpplib constexpr string view failure upstream

[BurningEnlightenment]

The MacOS unit test failure doesn't seem to be connected to this PR:

test 4
      Start  4: llfio_sl--clone_extents

4: Test command: /Users/runner/work/llfio/llfio/prebuilt/bin/llfio_sl--clone_extents "--reporter" "junit" "--out" "/Users/runner/work/llfio/llfio/prebuilt/bin/llfio_sl--clone_extents.junit.xml"
4: Working Directory: /Users/runner/work/llfio/llfio/prebuilt
4: Test timeout computed to be: 900
4: 
4: integration/llfio/algorithm/clone_extents : Tests that llfio::file_handle::clone_extents() of partial extents works as expected
4: 
4: 
4: integration/llfio/algorithm/clone_extents:
4: Tests that llfio::file_handle::clone_extents() of partial extents works as expected
4: 
4: Round 1: Cloning 18018052-4710497 to offset 32569981 ...
4: llfio: Freeing large pages failed
4: libc++abi: terminating
 4/93 Test  #4: llfio_sl--clone_extents ...................Subprocess aborted***Exception:   0.29 sec

The linux build failure seems to be caused by an outdated quickcpplib version:

 In file included from /home/runner/work/llfio/llfio/test/tests/../../include/llfio/v2.0/llfio.hpp:58:0,
                 from /home/runner/work/llfio/llfio/test/tests/../../include/llfio/llfio.hpp:18,
                 from /home/runner/work/llfio/llfio/test/tests/../test_kernel_decl.hpp:35,
                 from /home/runner/work/llfio/llfio/test/tests/tls_socket_handle.cpp:25:
/home/runner/work/llfio/llfio/test/tests/../../include/llfio/v2.0/config.hpp:271:2: warning: #warning WARNING: LLFIO is using the experimental Filesystem TS instead of the standard Filesystem, there are many corner case surprises in the former! Support for the Experimental Filesystem TS is expected to be deprecated at some point, and C++ 17 shall become the minimum required for LLFIO. [-Wcpp]
 #warning WARNING: LLFIO is using the experimental Filesystem TS instead of the standard Filesystem, there are many corner case surprises in the former! Support for the Experimental Filesystem TS is expected to be deprecated at some point, and C++ 17 shall become the minimum required for LLFIO.
  ^~~~~~~
/home/runner/work/llfio/llfio/test/tests/tls_socket_handle.cpp: In function ‘void TestAuthenticatingTLSSocketHandles()’:
/home/runner/work/llfio/llfio/test/tests/tls_socket_handle.cpp:287:61: error: ‘constexpr quickcpplib::_a2c4e5ab::string_view::basic_string_view<charT, traits>::basic_string_view(const charT*) [with charT = char; traits = std::char_traits<char>]’ called in a constant expression
   static constexpr llfio::string_view test_host("github.com");
                                                             ^
In file included from /home/runner/work/llfio/llfio/test/tests/../../include/llfio/v2.0/config.hpp:360:0,
                 from /home/runner/work/llfio/llfio/test/tests/../../include/llfio/v2.0/llfio.hpp:58,
                 from /home/runner/work/llfio/llfio/test/tests/../../include/llfio/llfio.hpp:18,
                 from /home/runner/work/llfio/llfio/test/tests/../test_kernel_decl.hpp:35,
                 from /home/runner/work/llfio/llfio/test/tests/tls_socket_handle.cpp:25:
/home/runner/work/llfio/llfio/prebuilt/install/include/quickcpplib/string_view.hpp:138:15: note: ‘constexpr quickcpplib::_a2c4e5ab::string_view::basic_string_view<charT, traits>::basic_string_view(const charT*) [with charT = char; traits = std::char_traits<char>]’ is not usable as a constexpr function because:
     constexpr basic_string_view(const charT *str)
               ^~~~~~~~~~~~~~~~~
/home/runner/work/llfio/llfio/prebuilt/install/include/quickcpplib/string_view.hpp:140:30: error: call to non-constexpr function ‘static std::size_t std::char_traits<char>::length(const char_type*)’
         , len_(traits::length(str))
                ~~~~~~~~~~~~~~^~~~~
/home/runner/work/llfio/llfio/test/tests/tls_socket_handle.cpp:291:3: error: ‘constexpr quickcpplib::_a2c4e5ab::string_view::basic_string_view<charT, traits>::basic_string_view(const charT*) [with charT = char; traits = std::char_traits<char>]’ called in a constant expression
 )");

[ned14]

Wish I had a Mac to test this stuff :(

Is it spurious or definitely repeatable?

[BurningEnlightenment]

Wish I had a Mac to test this stuff :(
Is it spurious or definitely repeatable?

I don't own one either. I just copy-pasted the CI log, but I might be able to borrow one from a work colleague tomorrow.

[BurningEnlightenment]

Is it spurious or definitely repeatable?

It occurred again, so it seems repeatable. Sadly I didn't get time on a MacOS computer.

The windows test failure is a byte_socket handle timeout which isn't caused by this AFAICT. So this is ready to be merged or am I missing something?

[ned14]

Surprises me that there isn't a link error not finding libdispatch on Mac OS, but I suppose without a Mac OS to check it's not worth worrying about.

[github-actions]

Unit Test Results

    6 files  +    4  192 suites  +128   31m 6s ⏱️ + 22m 8s
  57 tests ±    0    57 ✔️ ±    0  0 💤 ±0  0 ❌ ±0 
360 runs  +240  360 ✔️ +240  0 💤 ±0  0 ❌ ±0 

Results for commit 07488e1. ± Comparison against base commit 9ae8d87.