Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix Smoke Plus Fan Operation #47

Merged
merged 3 commits into from
Oct 25, 2021
Merged

Conversation

weberbox
Copy link
Contributor

When control['updated'] = True was removed in previous commits it created an issue where if Smoke Plus is toggled off when the fan is in an off state the fan never resumes again since the cycle is never restarted. I think this will resolve the issue.

…llet level notifications and related settings. Add RaspberryPi check to common.py for setting up modules. Changed Average Distance Measured to debug event. Added PYGAME240320B to modules.sh
@nebhead nebhead merged commit ff37017 into nebhead:development Oct 25, 2021
@nebhead
Copy link
Owner

nebhead commented Oct 25, 2021

Wow! Huge update - thank you for adding awesome new stuff and bug fixes!

@weberbox
Copy link
Contributor Author

Oh I didn't realize the installer stuff made it in here. Well great that it did. If you are interested you should now be able to run the Ant build script and it will spit out two deb packages one for rpi and one for other (pc testing mostly without the rpi dependencies). Just need to be in the project directory and then run command ant. I am doing this from Ubuntu but I think it might work on windows as well but would probably need a few other things installed. It is great for installing PiFire just run sudo apt install ./pifire_xxxx.deb and all dependencies are added then a modified version of the install script is run to finish the install and add the pip packages ask questions etc. I have already tested it on a pc and it seems to be working great but I am waiting on another pi zero to arrive so I have a desk test setup. It probably needs some tweaking but it is a great start to releasing debs if you ever want to.

Please note the deb packages change the install directory to /usr/local/bin/pifire. This was chosen so a pi user is not really required. It is also usually not a good practice to have deb's install to user's home folder anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants