[chunks] Fix bug that produced partial chunks were not inserted into cache #7795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issue: #7662 |
mzhangmzz
reviewed
Oct 11, 2022
| encoded_chunk, | ||
| &merkle_paths, | ||
| receipts, | ||
| )?; | ||
| Ok(()) | ||
| } | ||
|
|
There was a problem hiding this comment.
Can we add another CI test (or add an assertion in some existing tests) that covers this failure? It's a bit suboptimal that this is discovered in a nayduck test that is not super relevant to the chunks logic.
|
Added some new tests. |
mzhangmzz
approved these changes
Oct 12, 2022
…we produced the chunk
nikurt
pushed a commit
that referenced
this pull request
Nov 9, 2022
…cache (#7795) * [chunks] Fix bug that partial chunks were not inserted into cache if we produced the chunk * Add new tests for chunk cache behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was lost in the refactoring in #7695 .
It broke pytest/tests/sanity/block_sync_archival.py because the test asserted that the chunk producer should have all the chunks in the cache. This fixes the test now; I verified that the test failed right after #7695 (73de01b) and passes when this PR is applied right on top.
Unfortunately the test is currently broken at HEAD for a different reason.