Merged network-primitives into network package #7722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matklad
approved these changes
Sep 29, 2022
Comment on lines
+630
to
+631
| type From = near_network::types::AccountOrPeerIdOrHash; | ||
| type To = near_client_primitives::types::AccountOrPeerIdOrHash; |
There was a problem hiding this comment.
Nice pattern, going to add it to my toolbox!
| //! WARNING WARNING WARNING | ||
| //! We need to maintain backwards compatibility, all changes to this file needs to be reviews. | ||
| use crate::network_protocol::edge::{Edge, PartialEdgeInfo}; | ||
| use crate::network_protocol::{PeerChainInfoV2, PeerInfo, RoutedMessage}; |
There was a problem hiding this comment.
should we kill borsh already?
There was a problem hiding this comment.
I tried recently, but our python test suite is very messy and it would take me a few weeks to remove borsh usage there. I don't have that capacity now.
nikurt
pushed a commit
that referenced
this pull request
Nov 9, 2022
Part of the public API of network package was placed in near-network-primitives and part was in near-network. Hence most of the other packages imported both anyway. Merging them back together allows us to: - decrease the public API surface (since within a crate visibility settings are more flexible) - put API next to the only implementation of that API - decrease the confusion when importing network stuff in other packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the public API of network package was placed in near-network-primitives and part was in near-network. Hence most of the other packages imported both anyway. Merging them back together allows us to: