Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rand dependency to latest 0.8.5 version #7705

Merged
merged 2 commits into from
Sep 27, 2022
Merged

Conversation

mina86
Copy link
Contributor

@mina86 mina86 commented Sep 27, 2022

To make it work also update rand_xorshift to 0.3.

However, leave rand at 0.7 in core/crypto. This is because that crate
depends on ed25519-dalek which expects rand 0.7 objects.

Issue: #7674

To make it work also update rand_xorshift to 0.3.

However, leave rand at 0.7 in core/crypto.  This is because that
crate depends on ed25519-dalek which expects rand 0.7 objects.
Copy link
Contributor

@matklad matklad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

There's also a question of "will we break stuff" with rand upgrades, but we already have protocol_defining_rand infra for those cases, and hopefully they are exhaustive.

@near-bulldozer near-bulldozer bot merged commit d6dfc2b into near:master Sep 27, 2022
@mina86 mina86 deleted the c branch September 27, 2022 15:12
nikurt pushed a commit that referenced this pull request Nov 9, 2022
To make it work also update rand_xorshift to 0.3.

However, leave rand at 0.7 in core/crypto.  This is because that crate
depends on ed25519-dalek which expects rand 0.7 objects.

Issue: #7674
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants