Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prerender error fix #220

Merged
merged 2 commits into from
Jan 11, 2021
Merged

Prerender error fix #220

merged 2 commits into from
Jan 11, 2021

Conversation

anders-nom
Copy link
Contributor

@anders-nom anders-nom commented Jan 6, 2021

Feilen på redirect-url'er skyldes at nextjs forsøker å cache html'en for disse, som er undefined (ser ut som dette er en nextjs bug). Med Node v12 blir det skrevet en html-fil med innhold '[Object object]', men v14 gir en exception dersom en prøver å skrive undefined med writefile. Dette fører også til at json-cache'en ikke genereres for redirects.

Fra incremental-cache.ts i nextjs:

if (this.incrementalOptions.flushToDisk && !data.isNotFound) {
  try {
    const seedPath = this.getSeedPath(pathname, 'html')
    await promises.mkdir(path.dirname(seedPath), { recursive: true })
    await promises.writeFile(seedPath, data.html, 'utf8')
    await promises.writeFile(
      this.getSeedPath(pathname, 'json'),
      JSON.stringify(data.pageData),
      'utf8'
    )
  } catch (error) {
    // failed to flush to disk
    console.warn('Failed to update prerender files for', pathname, error)
  }
}

Kan gå tilbake til v14 når denne er fikset i nextjs: vercel/next.js#20816

@anders-nom anders-nom linked an issue Jan 6, 2021 that may be closed by this pull request
@anders-nom anders-nom merged commit ac236c0 into master Jan 11, 2021
@anders-nom anders-nom deleted the prerender-error branch January 11, 2021 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feil i logger ved redirect paths
2 participants