Optimize VLAN Adapter #350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Expand tests to cover ssh logic ---------
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
After 4.2.2 release
…tobot/nautobot-app-device-onboarding into dcates-optimize-vlan-adapter
Dav-C
requested review from
glennmatthews,
chadell,
susanhooks,
jeffkala and
scetron
as code owners
jeffkala
reviewed
Mar 31, 2025
jeffkala
reviewed
Mar 31, 2025
nautobot_device_onboarding/diffsync/adapters/sync_network_data_adapters.py
Outdated
Show resolved
Hide resolved
jeffkala
reviewed
Mar 31, 2025
nautobot_device_onboarding/diffsync/adapters/sync_network_data_adapters.py
Outdated
Show resolved
Hide resolved
…_adapters.py Co-authored-by: Jeff Kala <48843785+jeffkala@users.noreply.github.com>
Dav-C
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #278
What's Changed
When loading VLANs from Nautobot into the diffsync store, only VLANs with a location matching the location of at least 1 device selected to sync, are loaded.
VLANs are identified by a combination of ID and Location and will not be created unless a single unique location can be found using the name of the location assigned to the synced device. It has always been the case that VLAN assignments to interfaces required a VLAN with an ID and single location assigned, but this has been properly reflected in the VLAN model create method to prevent creation of VLANs without a location (and therefore never assigned to an interface).
To Do