-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
define readthedocs environment in terms of requirements files #1037
Merged
davemfish
merged 23 commits into
natcap:main
from
emlys:task/deduplicate-rtd-environment-file
Aug 23, 2022
Merged
define readthedocs environment in terms of requirements files #1037
davemfish
merged 23 commits into
natcap:main
from
emlys:task/deduplicate-rtd-environment-file
Aug 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lets also squash these commits before merging |
3 tasks
Sorry everyone! I accidentally closed this PR when I shouldn't have. Too many tabs open. |
davemfish
approved these changes
Aug 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I recently learned that you can reference
requirements.txt
files from a condaenvironment.yml
. Using that feature, we can deduplicate the ReadTheDocs environment file and be sure it's up to date.requirements-docs.yml
to.readthedocs_environment.yml
.readthedocs_environment.yml
, point to the requirements files rather than duplicating the list of requirements.readthedocs.yml
, update some deprecated syntax, and make use of the newjobs
feature to install invest withmake install
. This is nice because it's consistent with our other CI builds.In a second PR, I'd like to make some updates to the requirements files.
Checklist
Updated HISTORY.rst (if these changes are user-facing)Updated the user's guide (if needed)Tested the affected models' UIs (if relevant)