Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose subwatershed delineation #349

Closed
phargogh opened this issue Oct 19, 2020 · 3 comments · Fixed by #1291
Closed

Expose subwatershed delineation #349

phargogh opened this issue Oct 19, 2020 · 3 comments · Fixed by #1291
Assignees
@phargogh
Labels
in progress This issue is actively being worked on science request A request/proposal from within natcap related to science (rather than engineering)
Milestone
3.14.0

Comments

@phargogh
Copy link
Member

This is a placeholder issue for subwatershed delineation originally referenced in #147 . I'll fill in the issue details once I've finished working through the details of what this means with Stacie.
@phargogh phargogh added science request A request/proposal from within natcap related to science (rather than engineering) on hold There's a reason we're not working on this yet labels Oct 19, 2020
@phargogh phargogh self-assigned this Oct 19, 2020
@phargogh phargogh mentioned this issue Oct 19, 2020
Closed
@phargogh phargogh added this to the 3.10 milestone Nov 4, 2020
@phargogh
Copy link
Member Author

phargogh commented Jan 9, 2021

Rich ended up implementing subwatershed delineation in natcap/pygeoprocessing#128, natcap/pygeoprocessing#140 for a separate project for the freshwater team. I'll edit this to allow subwatershed delineation to be exposed in DelineateIt.

@phargogh phargogh changed the title Implement subwatershed delineation Expose subwatershed delineation Jan 9, 2021
@phargogh phargogh removed their assignment Jan 9, 2021
@phargogh
Copy link
Member Author

Let's get to this if we can, but if not it's OK to push off to the next release.

@dcdenu4 dcdenu4 modified the milestones: 3.10, 3.10.1 Dec 14, 2021
@emlys emlys removed the on hold There's a reason we're not working on this yet label Jan 14, 2022
@dcdenu4 dcdenu4 modified the milestones: 3.10.2, 3.10.3 Jan 28, 2022
@phargogh phargogh self-assigned this May 6, 2022
@phargogh phargogh added the in progress This issue is actively being worked on label May 6, 2022
phargogh added a commit to phargogh/invest that referenced this issue May 10, 2022
@phargogh
Committing work in progress on strahler streams
e01ab16 
RE:natcap#349
@davemfish davemfish modified the milestones: 3.11.0, 3.12 May 24, 2022
@dcdenu4 dcdenu4 modified the milestones: 3.12, 3.12.1 Aug 19, 2022
@phargogh phargogh modified the milestones: 3.12.1, 3.12.2 Dec 9, 2022
@phargogh phargogh modified the milestones: 3.12.2, 3.13.0 Jan 20, 2023
@phargogh phargogh modified the milestones: 3.13.0, 3.13.1 Mar 3, 2023
@phargogh
Copy link
Member Author

The last time I looked into this, I remember feeling some uncertainty around which tool to build subwatershed delineation into -- RouteDEM or DelineateIt.

Thinking about it a bit more, I think this belongs in RouteDEM because:

  • RouteDEM seems like a tool for creating layers derived only from the DEM. Since streams are derived from the DEM and subwatersheds are dependent on streams, this is the natural home for both strahler streams and subwatershed delineation.
  • DelineateIt is really about delineating watersheds from user-defined features, and subwatersheds just don't make sense in this case

phargogh added a commit to phargogh/invest that referenced this issue Apr 29, 2023
@phargogh
First stab on the stream order and sws delineation.
cd44d9b 
RE:natcap#349
phargogh added a commit to phargogh/invest that referenced this issue Apr 29, 2023
@phargogh
Creating a strahler stream order vector in RouteDEM.
f1bebaf 
RE:natcap#349
phargogh added a commit to phargogh/invest that referenced this issue Apr 29, 2023
@phargogh
Adding UI interactivity functions for new inputs.
841fa04 
RE:natcap#349
phargogh added a commit to phargogh/invest that referenced this issue Apr 29, 2023
@phargogh
Consolidating a conditional.
8eeadfe 
RE:natcap#349
phargogh added a commit to phargogh/invest that referenced this issue Apr 30, 2023
@phargogh
Adding output spec for strahler streams fields.
157ee31 
RE:natcap#349
phargogh added a commit to phargogh/invest that referenced this issue May 1, 2023
@phargogh
Adding model spec for subwatersheds vector. RE:natcap#349
3996983
phargogh added a commit to phargogh/invest that referenced this issue May 1, 2023
@phargogh
Correcting units. RE:natcap#349
c4d60f2
phargogh added a commit to phargogh/invest that referenced this issue May 1, 2023
@phargogh
Adding an about section for strahler stream vector.
16604cd 
RE:natcap#349
phargogh added a commit to natcap/invest.users-guide that referenced this issue May 2, 2023
@phargogh
Adding new investspec parameters for SWS delineation.
51e2fa7 
RE:natcap/invest#349
This was referenced May 2, 2023
Merged
Closed
phargogh added a commit to phargogh/invest that referenced this issue May 2, 2023
@phargogh
Bumping repository revisions for the updates.
d9cd10e 
RE:natcap#349
phargogh added a commit to phargogh/invest that referenced this issue May 2, 2023
@phargogh
Noting changes in HISTORY. RE:natcap#349
84ca5c8
phargogh added a commit to phargogh/invest that referenced this issue May 3, 2023
@phargogh
Removing todos, clarifying units for flow accumulation. RE:natcap#349
c03105e
phargogh added a commit to phargogh/invest that referenced this issue May 3, 2023
@phargogh
Correcting docs around raster x/y coordinates.
6adbea0 
RE:natcap#349
phargogh added a commit to phargogh/invest that referenced this issue May 3, 2023
@phargogh
Testing content of new vectors a bit. RE:natcap#349
5dfa2e1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phargogh phargogh

Labels
in progress This issue is actively being worked on science request A request/proposal from within natcap related to science (rather than engineering)
Projects
None yet
Milestone
3.14.0
Development

Successfully merging a pull request may close this issue.

Expose subwatershed delineation phargogh/invest
4 participants
@dcdenu4 @davemfish @phargogh @emlys