Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SWY cython is_close does not handle numpy.nan #1705

Closed
davemfish opened this issue Dec 11, 2024 · 0 comments · Fixed by #1706
Closed

SWY cython is_close does not handle numpy.nan #1705

davemfish opened this issue Dec 11, 2024 · 0 comments · Fixed by #1706
Assignees
@davemfish
Labels
bug Something isn't working
Milestone
3.14.3

Comments

@davemfish
Copy link
Contributor

We use an is_close function to check if pixel values are nodata. It's possible for a pixel value to be numpy.nan, so this function should allow for that.
@davemfish davemfish added the bug Something isn't working label Dec 11, 2024
@davemfish davemfish self-assigned this Dec 11, 2024
@davemfish davemfish added this to the 3.14.3 milestone Dec 11, 2024
davemfish added a commit to davemfish/invest that referenced this issue Dec 11, 2024
@davemfish
check for nan values when comparing doubles. natcap#1705
33b937c
davemfish added a commit to davemfish/invest that referenced this issue Dec 11, 2024
@davemfish
a note for HISTORY. natcap#1705
85bb331
@davemfish davemfish mentioned this issue Dec 11, 2024
Merged
3 tasks
davemfish added a commit to davemfish/invest that referenced this issue Dec 11, 2024
@davemfish
revert a comment. natcap#1705
5062fe3
@davemfish davemfish mentioned this issue Dec 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davemfish davemfish

Labels
bug Something isn't working
Projects
None yet
Milestone
3.14.3
Development

Successfully merging a pull request may close this issue.

SWY: check for numpy.nan pixels in routing functions davemfish/invest
1 participant
@davemfish