Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for excel files #1391

Closed
emlys opened this issue Aug 29, 2023 · 0 comments · Fixed by #1392
Closed

Drop support for excel files #1391

emlys opened this issue Aug 29, 2023 · 0 comments · Fixed by #1392
Assignees
@emlys
Labels
task Something needs to be done

Comments

@emlys
Copy link
Member

emlys commented Aug 29, 2023

The two HRA tables are the only places in invest where we allow Excel files.

Supporting Excel files requires some additional maintenance:

  • the excel_ok attribute in the model spec
  • extra code in validation to handle excel files
  • require extra dependencies (xlrd, openpyxl) necessary for pandas to read Excel files
  • HRA has its own table reading functions

It seems that the added maintenance costs are no longer worth it, especially as we are expanding CSV validation and type checking. I’m guessing we originally supported Excel because the HRA tables are complicated and it’s nice to work with them in a spreadsheet software, but users can still do that and export to CSV when they’re done. Stacie and Jade confirmed on slack that they are OK with using CSVs only.
@emlys emlys added the task Something needs to be done label Aug 29, 2023
@emlys emlys self-assigned this Aug 29, 2023
emlys added a commit to emlys/invest that referenced this issue Aug 29, 2023
@emlys
remove support for excel files natcap#1391
0eb35a1
@emlys emlys mentioned this issue Aug 29, 2023
Merged
3 tasks
emlys added a commit to emlys/invest that referenced this issue Aug 29, 2023
@emlys
history note for natcap#1391
6750b01
emlys added a commit to emlys/invest that referenced this issue Sep 5, 2023
@emlys
update users guide commit hash natcap#1391
6759fbe
emlys added a commit to emlys/invest that referenced this issue Sep 5, 2023
@emlys
update UG version again natcap#1391
a0a8b64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emlys emlys

Labels
task Something needs to be done
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove support for excel files emlys/invest
1 participant
@emlys