Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't call validate from execute #1373

Closed
emlys opened this issue Aug 15, 2023 · 0 comments · Fixed by #1375
Closed

Don't call validate from execute #1373

emlys opened this issue Aug 15, 2023 · 0 comments · Fixed by #1375
Assignees
@emlys
Labels
in progress This issue is actively being worked on task Something needs to be done

Comments

@emlys
Copy link
Member

emlys commented Aug 15, 2023

On the team call today, we decided to standardize on keeping validate orthogonal to execute. 5 models call validate at the start of execute, and some others duplicate validation in execute that's already handled in validate. We'll separate these out.
@emlys emlys added task Something needs to be done in progress This issue is actively being worked on labels Aug 15, 2023
@emlys emlys self-assigned this Aug 15, 2023
emlys added a commit to emlys/invest that referenced this issue Aug 15, 2023
@emlys
remove validate calls from execute functions natcap#1373
c9054d6
emlys added a commit to emlys/invest that referenced this issue Aug 16, 2023
@emlys
remove other duplicated validation from execute methods natcap#1373
0073cf0
@emlys emlys mentioned this issue Aug 16, 2023
Merged
3 tasks
emlys added a commit to emlys/invest that referenced this issue Aug 17, 2023
@emlys
moving rec model validation into validate method natcap#1373
8a90e7f
emlys added a commit to emlys/invest that referenced this issue Aug 17, 2023
@emlys
return validation messages rather than raising error natcap#1373
ea1a9dd
emlys added a commit to emlys/invest that referenced this issue Aug 17, 2023
@emlys
fix a few bugs introduced in merge and update tests for natcap#1373
0e0c7b1
emlys added a commit to emlys/invest that referenced this issue Aug 17, 2023
@emlys
fix ndr test natcap#1373
f82729b
emlys added a commit to emlys/invest that referenced this issue Aug 17, 2023
@emlys
history note for natcap#1373
d98528e
emlys added a commit to emlys/invest that referenced this issue Aug 18, 2023
@emlys
check if inputs are sufficent and valid before doing extra validation n…
e5a2292 
…atcap#1373
emlys added a commit to emlys/invest that referenced this issue Aug 18, 2023
@emlys
wind energy validation: read csv directly with pandas to avoid errors n…
7a2ad45 
…atcap#1373
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emlys emlys

Labels
in progress This issue is actively being worked on task Something needs to be done
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move validation out of execute methods emlys/invest
1 participant
@emlys