Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Middle-clicking a workbench tab opens a new blank window #1261

Closed
phargogh opened this issue Mar 17, 2023 · 3 comments · Fixed by #1371
Closed

Middle-clicking a workbench tab opens a new blank window #1261

phargogh opened this issue Mar 17, 2023 · 3 comments · Fixed by #1371
Assignees
Labels
bug Something isn't working in progress This issue is actively being worked on workbench For issues relating to the workbench front-end of invest
Milestone

Comments

@phargogh
Copy link
Member

When I ran an InVEST model in the workbench 3.13.0 release candidate, I went to close a model tab like I do in my web browser: by middle-clicking the tab. Doing so brought up a window:

Screenshot 2023-03-17 at 3 11 38 PM

I think I would expect it to close the tab, but maybe middle-click is supposed to indicate some other type of action?

To reproduce (at least on my mac):

  1. run a model in the workbench on the sample data
  2. When the model finishes executing, middle-click the model tab
  3. Observe new window opening.
@phargogh phargogh added the bug Something isn't working label Mar 17, 2023
@davemfish
Copy link
Contributor

davemfish commented Mar 20, 2023

Interesting, I'm not a middle-clicker, but this must be the default middle-click handler for links that is opening the new window. Despite the model tabs looking like tabs, they are in fact links:

<a href="#" role="tab" data-rb-event-key="2119562675" aria-selected="true" class="nav-link active"> Nutrient Delivery Ratio</a>

I think we could add a custom handler to support the middle-click-close-tab feature for these .nav-link. Should we leave the behavior for other links as-is? Such as the UG & Forum links.

@davemfish davemfish added the workbench For issues relating to the workbench front-end of invest label Mar 20, 2023
@dcdenu4
Copy link
Member

dcdenu4 commented Mar 20, 2023

this must be the default middle-click handler for links that is opening the new window. Despite the model tabs looking like tabs, they are in fact links

Yes, I'm always middle clicking links to open them in a new window, so this makes sense. But since they do look like tabs and act like tabs, I can see middle click closing them. But I would want to leave other links defaulted I think.

@davemfish
Copy link
Contributor

Let's support the middle-click close tab feature on these tabs. But not change the behavior for other links.

@davemfish davemfish added this to the 3.13.1 milestone Apr 7, 2023
@dcdenu4 dcdenu4 self-assigned this Aug 1, 2023
@dcdenu4 dcdenu4 added the in progress This issue is actively being worked on label Aug 11, 2023
dcdenu4 added a commit to dcdenu4/invest that referenced this issue Aug 11, 2023
dcdenu4 added a commit to dcdenu4/invest that referenced this issue Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in progress This issue is actively being worked on workbench For issues relating to the workbench front-end of invest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants