-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README output wrt added Go versions #161
Conversation
WalkthroughThe changes to the Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- README.md (4 hunks)
Additional context used
LanguageTool
README.md
[style] ~16-~16: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ... by "go install" to the latest version. gup updates all binaries in parallel, so ve...
[uncategorized] ~18-~18: When ‘set-up’ is used as a noun or modifier, it needs to be hyphenated. (VERB_NOUN_CONFUSION)
Context: ... using oh-my-zsh, then gup has an alias set up. The alias isgup - git pull --rebase
...
[style] ~18-~18: Consider using a different verb to strengthen your wording. (MAKE_SURE_ENSURE)
Context: ...- git pull --rebase`. Therefore, please make sure that the oh-my-zsh alias is disabled (e...
[grammar] ~29-~29: The pronoun ‘you’ must be used with a non-third-person form of a verb. (NON3PRS_VERB)
Context: ... to install ### Use "go install" If you does not have the golang development environ...
[style] ~88-~88: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing. (REP_WANT_TO_VB)
Context: ...mand. The remove subcommand asks if you want to remove it before removing it. ``` $ gup...
[style] ~99-~99: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing. (REP_WANT_TO_VB)
Context: ...ved /home/nao/.go/bin/ubume ``` If you want to force the removal, use the --force opti...
[style] ~106-~106: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing. (REP_WANT_TO_VB)
Context: ...the binary is the latest version If you want to know if the binary is the latest versio...
[style] ~130-~130: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing. (REP_WANT_TO_VB)
Context: ...o $XDG_CONFIG_HOME/gup/gup.conf. If you want to know [XDG Base Directory Specification]...
[grammar] ~130-~130: There seems to be a noun/verb agreement error. Did you mean “starts” or “started”? (SINGULAR_NOUN_VERB_AGREEMENT)
Context: ...tem, you execute import-subcommand. gup start the installation according to the conte...
[grammar] ~181-~181: There is an agreement error between ‘use’ and ‘gup’. Insert ‘a(n)’ or change the noun to plural. (PRP_VB_NN)
Context: ...up ``` ### Desktop notification If you use gup with --notify option, gup command notif...
[uncategorized] ~197-~197: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: ... tests. The sqly is unit tested for all packages as the unit test tree map below shows. ...
[typographical] ~217-~217: It seems that a comma is missing. (THANKS_COMMA)
Context: ...e 2.0](./LICENSE). ## Contributors ✨ Thanks goes to these wonderful people ([emoji ...
[style] ~247-~247: Using many exclamation marks might seem excessive (in this case: 9 exclamation marks for a text that’s 5635 characters long) (EN_EXCESSIVE_EXCLAMATION)
Context: ...ation. Contributions of any kind welcome!
Markdownlint
README.md
42-42: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
188-188: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
215-215: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
74-74: null (MD014, commands-show-output)
Dollar signs used before commands without showing output
80-80: null (MD014, commands-show-output)
Dollar signs used before commands without showing output
183-183: null (MD014, commands-show-output)
Dollar signs used before commands without showing output
13-13: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
22-22: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
27-27: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
28-28: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
28-28: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
34-34: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
39-39: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
43-43: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
44-44: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
44-44: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
60-60: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
70-70: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
77-77: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
83-83: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
87-87: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
105-105: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
129-129: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
129-129: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
153-153: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
170-170: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
180-180: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
189-189: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
193-193: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
196-196: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
201-201: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
212-212: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
30-30: null (MD031, blanks-around-fences)
Fenced code blocks should be surrounded by blank lines
35-35: null (MD031, blanks-around-fences)
Fenced code blocks should be surrounded by blank lines
62-62: null (MD031, blanks-around-fences)
Fenced code blocks should be surrounded by blank lines
73-73: null (MD031, blanks-around-fences)
Fenced code blocks should be surrounded by blank lines
79-79: null (MD031, blanks-around-fences)
Fenced code blocks should be surrounded by blank lines
89-89: null (MD031, blanks-around-fences)
Fenced code blocks should be surrounded by blank lines
100-100: null (MD031, blanks-around-fences)
Fenced code blocks should be surrounded by blank lines
107-107: null (MD031, blanks-around-fences)
Fenced code blocks should be surrounded by blank lines
120-120: null (MD031, blanks-around-fences)
Fenced code blocks should be surrounded by blank lines
128-128: null (MD031, blanks-around-fences)
Fenced code blocks should be surrounded by blank lines
145-145: null (MD031, blanks-around-fences)
Fenced code blocks should be surrounded by blank lines
155-155: null (MD031, blanks-around-fences)
Fenced code blocks should be surrounded by blank lines
182-182: null (MD031, blanks-around-fences)
Fenced code blocks should be surrounded by blank lines
184-184: null (MD031, blanks-around-fences)
Fenced code blocks should be surrounded by blank lines
207-207: null (MD031, blanks-around-fences)
Fenced code blocks should be surrounded by blank lines
23-23: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
30-30: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
47-47: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
62-62: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
73-73: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
79-79: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
89-89: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
100-100: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
107-107: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
120-120: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
133-133: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
145-145: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
155-155: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
173-173: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
182-182: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
207-207: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
Additional comments not posted (4)
README.md (4)
50-55
: Updated output format to include Go version is clear and informative.The updates made to the output format, which now includes the Go version alongside the binary version, enhance the clarity and detail of the information provided to the user. This change aligns with the PR's objective to reflect the enhancements made by PR #156.
65-67
: Clear presentation of updated and current Go versions in the output.The inclusion of both the updated and current Go versions for each binary during the update process provides users with valuable information for managing their environments. This change is consistent with the stated objectives of the PR.
111-113
: Enhanced output details in the check subcommand.The modifications to the output of the check subcommand, which now shows the Go version used along with the binary version status, are useful for users to quickly assess the state of their installations.
123-124
: Consistent formatting in output for specified binary checks.The output for checking specified binaries now uniformly includes Go version details, maintaining consistency across different subcommands. This enhancement supports better version management and clarity for the user.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- README.md (4 hunks)
Additional context used
LanguageTool
README.md
[style] ~16-~16: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ... by "go install" to the latest version. gup updates all binaries in parallel, so ve...
[uncategorized] ~18-~18: When ‘set-up’ is used as a noun or modifier, it needs to be hyphenated. (VERB_NOUN_CONFUSION)
Context: ... using oh-my-zsh, then gup has an alias set up. The alias isgup - git pull --rebase
...
[style] ~18-~18: Consider using a different verb to strengthen your wording. (MAKE_SURE_ENSURE)
Context: ...- git pull --rebase`. Therefore, please make sure that the oh-my-zsh alias is disabled (e...
[grammar] ~29-~29: The pronoun ‘you’ must be used with a non-third-person form of a verb. (NON3PRS_VERB)
Context: ... to install ### Use "go install" If you does not have the golang development environ...
[style] ~88-~88: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing. (REP_WANT_TO_VB)
Context: ...mand. The remove subcommand asks if you want to remove it before removing it. ``` $ gup...
[style] ~99-~99: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing. (REP_WANT_TO_VB)
Context: ...ved /home/nao/.go/bin/ubume ``` If you want to force the removal, use the --force opti...
[style] ~106-~106: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing. (REP_WANT_TO_VB)
Context: ...the binary is the latest version If you want to know if the binary is the latest versio...
[style] ~130-~130: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing. (REP_WANT_TO_VB)
Context: ...o $XDG_CONFIG_HOME/gup/gup.conf. If you want to know [XDG Base Directory Specification]...
[grammar] ~130-~130: There seems to be a noun/verb agreement error. Did you mean “starts” or “started”? (SINGULAR_NOUN_VERB_AGREEMENT)
Context: ...tem, you execute import-subcommand. gup start the installation according to the conte...
[grammar] ~181-~181: There is an agreement error between ‘use’ and ‘gup’. Insert ‘a(n)’ or change the noun to plural. (PRP_VB_NN)
Context: ...up ``` ### Desktop notification If you use gup with --notify option, gup command notif...
[uncategorized] ~197-~197: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: ... tests. The sqly is unit tested for all packages as the unit test tree map below shows. ...
[typographical] ~217-~217: It seems that a comma is missing. (THANKS_COMMA)
Context: ...e 2.0](./LICENSE). ## Contributors ✨ Thanks goes to these wonderful people ([emoji ...
[style] ~247-~247: Using many exclamation marks might seem excessive (in this case: 9 exclamation marks for a text that’s 5635 characters long) (EN_EXCESSIVE_EXCLAMATION)
Context: ...ation. Contributions of any kind welcome!
Markdownlint
README.md
42-42: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
188-188: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
215-215: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
74-74: null (MD014, commands-show-output)
Dollar signs used before commands without showing output
80-80: null (MD014, commands-show-output)
Dollar signs used before commands without showing output
183-183: null (MD014, commands-show-output)
Dollar signs used before commands without showing output
13-13: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
22-22: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
27-27: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
28-28: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
28-28: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
34-34: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
39-39: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
43-43: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
44-44: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
44-44: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
60-60: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
70-70: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
77-77: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
83-83: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
87-87: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
105-105: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
129-129: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
129-129: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
153-153: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
170-170: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
180-180: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
189-189: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
193-193: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
196-196: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
201-201: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
212-212: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
30-30: null (MD031, blanks-around-fences)
Fenced code blocks should be surrounded by blank lines
35-35: null (MD031, blanks-around-fences)
Fenced code blocks should be surrounded by blank lines
62-62: null (MD031, blanks-around-fences)
Fenced code blocks should be surrounded by blank lines
73-73: null (MD031, blanks-around-fences)
Fenced code blocks should be surrounded by blank lines
79-79: null (MD031, blanks-around-fences)
Fenced code blocks should be surrounded by blank lines
89-89: null (MD031, blanks-around-fences)
Fenced code blocks should be surrounded by blank lines
100-100: null (MD031, blanks-around-fences)
Fenced code blocks should be surrounded by blank lines
107-107: null (MD031, blanks-around-fences)
Fenced code blocks should be surrounded by blank lines
120-120: null (MD031, blanks-around-fences)
Fenced code blocks should be surrounded by blank lines
128-128: null (MD031, blanks-around-fences)
Fenced code blocks should be surrounded by blank lines
145-145: null (MD031, blanks-around-fences)
Fenced code blocks should be surrounded by blank lines
155-155: null (MD031, blanks-around-fences)
Fenced code blocks should be surrounded by blank lines
182-182: null (MD031, blanks-around-fences)
Fenced code blocks should be surrounded by blank lines
184-184: null (MD031, blanks-around-fences)
Fenced code blocks should be surrounded by blank lines
207-207: null (MD031, blanks-around-fences)
Fenced code blocks should be surrounded by blank lines
23-23: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
30-30: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
47-47: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
62-62: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
73-73: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
79-79: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
89-89: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
100-100: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
107-107: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
120-120: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
133-133: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
145-145: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
155-155: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
173-173: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
182-182: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
207-207: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
Additional comments not posted (3)
README.md (3)
50-55
: Updated Go version information in output formatThe changes made to include the Go version alongside the binary versions in the output format are accurate and align with the PR's objective to provide more detailed status updates. This enhancement improves the clarity and usability of the information presented to the user.
65-67
: Consistent Go version information in specific binary updatesThe inclusion of Go version details in the update logs for specific binaries (like
gup
andubume
) is consistent with the changes made in the general update section. This ensures uniformity in the information provided across different sections of the README.
[APROVED]
111-113
: Enhanced clarity in binary version checksThe update to show both the current and the installed Go versions when checking binary versions adds a layer of detail that enhances user understanding of the environment their binaries operate in. This change is well-executed and supports the overall goal of the PR.
Thank you for updating the README. |
Closes #157
Summary by CodeRabbit
gup
tool output to include Go version information alongside binary versions, providing more comprehensive status updates during binary updates and version checks.