Store pointer to boost::asio::signal_set and cancel when ipc_server::stop is called. #4367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsiganos
reviewed
Jan 18, 2024
|
I think we should try to follow the pattern we started of calling stop() to an object and not stopping from the destructor. |
…stop is called. Previously the signals weren't cancelled on ipc_server and would remain running until the io_context was destroyed.
clemahieu
force-pushed
the
ipc_server_signals
branch
from
914dc12 to
b0896aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the signals weren't cancelled on ipc_server and would remain running until the io_context was destroyed.