refactor: remove onChangedNullable, update onChanged for null val…
#177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ues, and set `allowDeselection` default to false This commit introduces breaking changes: 1. Removed the `onChangedNullable` method to simplify the API and avoid developer confusion. The `onChanged` method now supports returning or callback with a null value. Developers must implement null checks in their code to handle nullable results from `onChanged`. 2. The `allowDeselection` property now defaults to `false`. Ensure your code explicitly sets this to `true` if deselection is needed. Please update your code to accommodate these changes.
nank1ro
requested changes
Oct 26, 2024
|
I set the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ues, and set
allowDeselectiondefault to falseThis commit introduces breaking changes:
Removed the
onChangedNullablemethod to simplify the API and avoid developer confusion. TheonChangedmethod now supports returning or callback with a null value. Developers must implement null checks in their code to handle nullable results fromonChanged.The
allowDeselectionproperty now defaults tofalse. Ensure your code explicitly sets this totrueif deselection is needed. However, when the variant is multiple, theallowDeselectionproperty defaults totrue.Please update your code to accommodate these changes.