fix: input read-only (#290)

nank1ro · Feb 10, 2025 · a8a44c2 · a8a44c2
1 parent bec1b21
commit a8a44c2
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 0.19.0
+
+- **FIX**: `ShadInput` `readOnly` not updating.
+
 ## 0.18.7
 
 - **FIX**: `ShadApp` dark theme behavior now is the same as Material. The dark theme is applied only if you provide a `darkTheme` and the user theme mode is dark

diff --git a/lib/src/components/input.dart b/lib/src/components/input.dart
@@ -215,11 +215,9 @@ class ShadInputState extends State<ShadInput>
     }
 
     if (widget.readOnly != oldWidget.readOnly) {
-      _focusNode?.canRequestFocus = widget.readOnly;
-    }
-
-    if (effectiveFocusNode.hasFocus && widget.readOnly != oldWidget.readOnly) {
-      if (effectiveController.selection.isCollapsed) {
+      effectiveFocusNode.canRequestFocus = !widget.readOnly;
+      if (effectiveFocusNode.hasFocus &&
+          effectiveController.selection.isCollapsed) {
         _showSelectionHandles = !widget.readOnly;
       }
     }

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -1,6 +1,6 @@
 name: shadcn_ui
 description: shadcn-ui ported in Flutter. Awesome UI components for Flutter, fully customizable.
-version: 0.18.7
+version: 0.19.0
 homepage: https://flutter-shadcn-ui.mariuti.com
 repository: https://github.com/nank1ro/flutter-shadcn-ui
 documentation: https://flutter-shadcn-ui.mariuti.com