Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix print pretty #707

Merged
merged 6 commits into from
Jan 8, 2021
Merged

Fix print pretty #707

merged 6 commits into from
Jan 8, 2021

Conversation

2bndy5
Copy link
Member

@2bndy5 2bndy5 commented Dec 27, 2020 •
edited
Loading

Fixes #706 and closes #716. Both fixes in this PR resolves errors noticed by @combs & @DrClaudio73

  1. Use binary representation to show the auto-ack feature when configuration differs per pipe
  2. Uses correct mnemonic to output "primary mode"

Tested changes using python wrapper; it works as expected.

@2bndy5 2bndy5 mentioned this pull request Jan 7, 2021
Closed
@2bndy5 2bndy5 requested review from Avamander and TMRh20 January 8, 2021 00:01
@2bndy5 2bndy5 merged commit 38b1205 into master Jan 8, 2021
@2bndy5 2bndy5 deleted the fix-printPretty branch January 8, 2021 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TMRh20 TMRh20 TMRh20 approved these changes

@Avamander Avamander Awaiting requested review from Avamander

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

printPrettyDetails - Primary Mode better auto-ack representation in printPrettyDetail()
2 participants
@2bndy5 @TMRh20